magento/magento2: #8765 #8778
Merged
magento/magento2: #8765 #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 2, 2017 15:47
…nfig\SourceFactory::create() method is wrong Fixed type in return comment
A PHPDoc comment for \Magento\Config\Model\Config\SourceFactory::create() method is wrong The correct return parameter is \Magento\Framework\Option\ArrayInterface
Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative - fixed adding a strong check on return value
orlangur
requested changes
Mar 3, 2017
| @@ -568,6 +568,6 @@ public function getAttributeRawValue($entityId, $attribute, $store) | |||
| $attributesData = $_data[1]; | |||
| } | |||
|
|
|||
| return $attributesData ? $attributesData : false; | |||
| return $attributesData!==false ? $attributesData : false; | |||
There was a problem hiding this comment.
Please add spaces around binary operator.
Also, as to me this statement would be less confusing if you invert condition (=== false and swap ternary operator parts).
Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative - fixed adding a strong check on return value
orlangur
requested changes
Mar 3, 2017
| @@ -568,6 +568,6 @@ public function getAttributeRawValue($entityId, $attribute, $store) | |||
| $attributesData = $_data[1]; | |||
| } | |||
|
|
|||
| return $attributesData ? $attributesData : false; | |||
| return $attributesData === false ? false: $attributesData; | |||
There was a problem hiding this comment.
Thanks! Just one more space in false: left to add :)
It would be really nice if you squash all changes into one commit and force push into the same branch, but I do not insist on this.
There was a problem hiding this comment.
Fixed.. but i've still have some problem with squash :D
Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative - fixed adding a strong check on return value
orlangur
approved these changes
Mar 3, 2017
maghamed
approved these changes
Mar 22, 2017
magento-team
pushed a commit
that referenced
this pull request
Mar 22, 2017
|
@cavalier79 Thank you, accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M2.1.4 : Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative