Explace the direct usage of Zend_Json with a call to the Json Help class #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakhsuvarov
requested changes
Apr 21, 2017
| @@ -487,7 +487,7 @@ window.WidgetInstance = WidgetInstance; | |||
|
|
|||
| jQuery(function(){ | |||
| <?php foreach ($block->getPageGroups() as $pageGroup): ?> | |||
| WidgetInstance.addPageGroup(<?php /* @noEscape */ echo Zend_Json::encode($pageGroup) ?>); | |||
| WidgetInstance.addPageGroup(<?php /* @noEscape */ echo $this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($pageGroup) ?>); | |||
There was a problem hiding this comment.
This class is deprecated.
Please change to \Magento\Framework\Serialize\Serializer\Json
ishakhsuvarov
approved these changes
May 20, 2017
magento-team
pushed a commit
that referenced
this pull request
Jun 1, 2017
…he Json Help class #9344
magento-team
pushed a commit
that referenced
this pull request
Jun 1, 2017
…he Json Help class #9344
magento-team
pushed a commit
that referenced
this pull request
Jun 1, 2017
[EngCom] Public Pull Requests - MAGETWO-69573: Adding logo in media folder #9797 - MAGETWO-69555: Allow for referenceBlock to include template argument #9772 - MAGETWO-69540: Fix for #5897: getIdentities relies on uninitialized collection #9777 - MAGETWO-69533: [BUGFIX][6244] Fix Issue with code label display in cart checkout. #9721 - MAGETWO-69499: Update select.js #9475 - MAGETWO-69451: Replace Zend_Json in the configurable product block test #9753 - MAGETWO-69373: Customer with unique attribute can't be saved #7844 #9712 - MAGETWO-69369: Replace the direct usage of Zend_Json with a call to the Json Help class #9344 - MAGETWO-69085: Do not hardcode product link types #9600 - MAGETWO-69554: Patch to allow multiple filter_url_params to function #9723
|
@dmanners thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Zend1 is at EOL we should replace any usage of it's elements. For this case we are removing Zend_Json #9236
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist