Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for referenceBlock to include template argument #9772

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Allow for referenceBlock to include template argument #9772

merged 2 commits into from
Jun 1, 2017

Conversation

jissereitsma
Copy link
Contributor

@jissereitsma jissereitsma commented May 28, 2017 •
edited by ishakhsuvarov
Loading

Reference #9771

@maghamed maghamed self-assigned this May 29, 2017
@maghamed maghamed self-requested a review May 29, 2017 08:02
@korostii
Copy link
Contributor

This is a great suggestion!
But shouldn't the element type be xs:string instead of xs:boolean?

@jissereitsma
Copy link
Contributor Author

@korostii OMG, sure it needs to be string instead of boolean. Sorry for being so careless and thanks for spotting that glitch. Never make a PR after drinking 2 beers on a warm Sunday afternoon.

maghamed
maghamed approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@maghamed maghamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ishakhsuvarov ishakhsuvarov self-assigned this May 30, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 30, 2017
@fooman
Copy link
Contributor

fooman commented May 30, 2017

Never make a PR after drinking 2 beers on a warm Sunday afternoon.

@jissereitsma where is the fun in that?

@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@magento-team magento-team merged commit f99a9ef into magento:develop Jun 1, 2017
magento-team pushed a commit that referenced this pull request Jun 1, 2017
@ishakhsuvarov
MAGETWO-69555: Allow for referenceBlock to include template argument #…
66b213e 
…9772
magento-team pushed a commit that referenced this pull request Jun 1, 2017
@ishakhsuvarov
Merge pull request #1158 from magento-engcom/develop-prs
6e15e7d 
[EngCom] Public Pull Requests
 - MAGETWO-69573: Adding logo in media folder #9797
 - MAGETWO-69555: Allow for referenceBlock to include template argument #9772
 - MAGETWO-69540: Fix for #5897: getIdentities relies on uninitialized collection #9777
 - MAGETWO-69533: [BUGFIX][6244] Fix Issue with code label display in cart checkout. #9721
 - MAGETWO-69499: Update select.js #9475
 - MAGETWO-69451: Replace Zend_Json in the configurable product block test #9753
 - MAGETWO-69373: Customer with unique attribute can't be saved #7844 #9712
 - MAGETWO-69369: Replace the direct usage of Zend_Json with a call to the Json Help class #9344
 - MAGETWO-69085: Do not hardcode product link types #9600
 - MAGETWO-69554: Patch to allow multiple filter_url_params to function #9723
@magento-team
Copy link
Contributor

@jissereitsma thank you for your contribution. Your Pull Request has been successfully merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korostii korostii korostii approved these changes

@maghamed maghamed maghamed approved these changes

Assignees

@maghamed maghamed

@ishakhsuvarov ishakhsuvarov

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.
7 participants
@jissereitsma @korostii @fooman @magento-team @maghamed @ishakhsuvarov @okorshenko