-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Implement Image gallery with zoom #1276
Comments
@soumya-ashok can you comment one way or other as to whether we want to add the "zoom" feature to our PDP images? If so we should discuss that here before you rework your PR @binucorra |
@sirugh The design has an affordance for the zoom functionality on the PDP per this mockup - https://magento.invisionapp.com/share/YGOC5FM6EBQ We have never discussed how we would like this functionality to work. Are we able to allow pinch-zoom on Venia? |
Pinch and zoom currently works on mobile through the native browser "magnifying" the page. I can show you in person if you like. This specific issue that was opened, based on the PR, seems to be wanting zooming on desktop. |
@binucorra After discussion with @sirugh the direction we would like to adopt for the desktop zoom feature is to click the zoom icon, which will open a full screen gallery view with thumbnails, similar to what happens when you click the product image here - https://www.westelm.com/products/modern-industrial-metal-wood-writing-desk-h3541/?pkey=coffice-desks&isx=0.0 or with any products on Amazon with the option to further zoom in the gallery view. In addition to static images, we would need to support videos. We would not include zoom on hover. This is not a feature that the team currently has on its priority list, but we are open to receiving contributions. If you would like to work on this feature, I'll be happy to provide a mockup and have a discussion on the interactions needed. |
@soumya-ashok |
@binucorra Sounds good, I should be able to work on this next week. @sirugh Should we open a new issue with the mockups? |
@soumya-ashok no need, just edit this one. |
Yes, @soumya-ashok Please edit this one. |
@magento export issue to JIRA project PWA as Story |
✅ Jira issue https://jira.corp.magento.com/browse/PWA-1753 is successfully created for this GitHub issue. |
Description
Implement Zoom gallery in product detail page
Packages used
React magnify: https://www.npmjs.com/package/react-image-magnify
React Slick: https://www.npmjs.com/package/react-slick
Please let us know what packages this feature is in regards to:
venia-concept
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
The text was updated successfully, but these errors were encountered: