Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Implement Image gallery with zoom #1276

Open
1 of 6 tasks
binucorra opened this issue May 28, 2019 · 10 comments
Open
1 of 6 tasks

[feature]: Implement Image gallery with zoom #1276

binucorra opened this issue May 28, 2019 · 10 comments
Labels
enhancement New feature or request needs-ux Collaboration and review from UX team is required Progress: ready for grooming

Comments

@binucorra
Copy link

Description
Implement Zoom gallery in product detail page
Packages used
React magnify: https://www.npmjs.com/package/react-image-magnify
React Slick: https://www.npmjs.com/package/react-slick

Screenshot 2019-05-28 at 6 47 56 PM

Screenshot 2019-05-28 at 6 48 38 PM

Please let us know what packages this feature is in regards to:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@binucorra binucorra added the enhancement New feature or request label May 28, 2019
@sirugh sirugh added the needs-ux Collaboration and review from UX team is required label Jun 5, 2019
@sirugh
Copy link
Contributor

sirugh commented Jul 10, 2019

@soumya-ashok can you comment one way or other as to whether we want to add the "zoom" feature to our PDP images? If so we should discuss that here before you rework your PR @binucorra

@soumya-ashok
Copy link

@sirugh The design has an affordance for the zoom functionality on the PDP per this mockup - https://magento.invisionapp.com/share/YGOC5FM6EBQ

We have never discussed how we would like this functionality to work. Are we able to allow pinch-zoom on Venia?

@sirugh
Copy link
Contributor

sirugh commented Jul 10, 2019

Pinch and zoom currently works on mobile through the native browser "magnifying" the page. I can show you in person if you like. This specific issue that was opened, based on the PR, seems to be wanting zooming on desktop.

@soumya-ashok
Copy link

@binucorra After discussion with @sirugh the direction we would like to adopt for the desktop zoom feature is to click the zoom icon, which will open a full screen gallery view with thumbnails, similar to what happens when you click the product image here - https://www.westelm.com/products/modern-industrial-metal-wood-writing-desk-h3541/?pkey=coffice-desks&isx=0.0 or with any products on Amazon with the option to further zoom in the gallery view.

In addition to static images, we would need to support videos.

We would not include zoom on hover.

This is not a feature that the team currently has on its priority list, but we are open to receiving contributions. If you would like to work on this feature, I'll be happy to provide a mockup and have a discussion on the interactions needed.

@binucorra
Copy link
Author

@soumya-ashok
Thanks for following this issue. I'd like to continue my contributions. Please provide the mockup.

@soumya-ashok
Copy link

@binucorra Sounds good, I should be able to work on this next week. @sirugh Should we open a new issue with the mockups?

@sirugh
Copy link
Contributor

sirugh commented Jul 12, 2019

@soumya-ashok no need, just edit this one.

@binucorra
Copy link
Author

Yes, @soumya-ashok Please edit this one.

@awilcoxa awilcoxa added this to the Storefront and Theming milestone Sep 16, 2019
@awilcoxa awilcoxa removed this from the Storefront and Theming milestone Oct 16, 2019
@sirugh
Copy link
Contributor

sirugh commented May 17, 2021

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-1753 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-ux Collaboration and review from UX team is required Progress: ready for grooming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants