Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zoom gallery product #1277

Closed

Conversation

binucorra
Copy link

@binucorra binucorra commented May 28, 2019

Description

Related Issue

Closes #1276

Verification Steps

  1. Go product detail page.
    https://venia-jn8dvoshz.now.sh/valeria-two-layer-tank.html
  2. Mouse over on the main image.
  3. Make sure zoom image is showing inline.

How Have YOU Tested this?

Screenshots / Screen Captures (if appropriate):

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@magento-cicd2
Copy link

magento-cicd2 commented May 28, 2019

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented May 28, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-fork-binucorra-feature-zoom-gallery-product.magento-research1.now.sh

@sirugh
Copy link
Contributor

sirugh commented Jul 10, 2019

Closing this as we are in the middle of refactoring the PDP images in #1268. I've also requested that UX take a look at your original issue so we can discuss whether or not this is a feature we want to implement within our example storefront. Thanks for your contribution, though! In the future, if you open an issue beforehand we can discuss approaches before you spend too much time writing code :)

@sanganinamrata
Copy link
Member

@sirugh Hello, Any update on zoom gallery feature on PWA studio?

@dawidow
Copy link

dawidow commented Mar 9, 2023

I also with a question, will this topic be continued?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Implement Image gallery with zoom
5 participants