-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Add Sorting feature to Search Results Page #2227
Comments
@larsroettig just to follow up on the conversation from last community sync, created the follow on issue we discussed. |
@awilcoxa if like you can assign me I will work on this next week |
@larsroettig just giving my 2 cents here but I think we should make the sorting a dropdown-select so the user has visual confirmation on what's the current sorting order. Right now a user needs to click 'Sort' before they can see context. @soumya-ashok what do you think ? |
@Jordaneisenburger Not sure I fully understand your feedback. Are you saying that instead of the label "sort" the button should have the current sorting label added "sort : newest"? The design intent is to have it function as a dropdown once the button is tapped/clicked. |
@soumya-ashok exactly, as a user I don't want to lose context, see above image (it's Dutch but you get the point) The same applies for the filters in some way, we should be able to see active filters or an indicator that there are filters active when the drawer is closed. |
@Jordaneisenburger - Agree with your feedback on providing context to the user. However, the way we are currently set up with the placement of the buttons for filter and sort (particularly on mobile) makes it challenging to implement something that looks like your screenshot in terms of having the space to add the additional text outside the dropdown. @schensley has some ways we could make the design look consistent on both desktop and mobile. @larsroettig could you please work with the design that Scott provides to make improvements? |
Hi. @larsroettig NOTE: I've made a simple wireframe demo. |
@Jordaneisenburger if you are going to update this, then the product listing sorting option would also be updated right? |
@larsroettig any updates? |
@awilcoxa I started working on it but then I have to move |
Is your feature request related to a problem? Please describe.
Category sorting was implemented in #360 and now needs to also be implemented for the search results page.
As a shopper, after I use the search feature to find specific items in the store I want to be able to sort the returned products by the available criteria: price (low to high), price (high to low), best match
Describe the solution you'd like
Implement existing category sorting feature on search results page.
Sort button should display and support all currently available sorting options
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Please let us know what packages this feature is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: