Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Add Sorting feature to Search Results Page #2227

Closed
6 tasks
awilcoxa opened this issue Mar 9, 2020 · 10 comments · Fixed by #2294
Closed
6 tasks

[feature]: Add Sorting feature to Search Results Page #2227

awilcoxa opened this issue Mar 9, 2020 · 10 comments · Fixed by #2294
Assignees
Labels
enhancement New feature or request help wanted Eligible for community contribution.

Comments

@awilcoxa
Copy link

awilcoxa commented Mar 9, 2020

Is your feature request related to a problem? Please describe.
Category sorting was implemented in #360 and now needs to also be implemented for the search results page.

As a shopper, after I use the search feature to find specific items in the store I want to be able to sort the returned products by the available criteria: price (low to high), price (high to low), best match

Describe the solution you'd like
Implement existing category sorting feature on search results page.

Sort button should display and support all currently available sorting options

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Please let us know what packages this feature is in regards to:

  • venia-concept
  • [x ] venia-ui
  • pwa-buildpack
  • [ x] peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@awilcoxa awilcoxa added the enhancement New feature or request label Mar 9, 2020
@awilcoxa awilcoxa added the help wanted Eligible for community contribution. label Mar 9, 2020
@awilcoxa
Copy link
Author

awilcoxa commented Mar 9, 2020

@larsroettig just to follow up on the conversation from last community sync, created the follow on issue we discussed.

@larsroettig
Copy link
Member

@awilcoxa if like you can assign me I will work on this next week

@Jordaneisenburger
Copy link
Member

@larsroettig just giving my 2 cents here but I think we should make the sorting a dropdown-select so the user has visual confirmation on what's the current sorting order. Right now a user needs to click 'Sort' before they can see context.

@soumya-ashok what do you think ?

@soumya-ashok
Copy link

@Jordaneisenburger Not sure I fully understand your feedback. Are you saying that instead of the label "sort" the button should have the current sorting label added "sort : newest"?

The design intent is to have it function as a dropdown once the button is tapped/clicked.

@Jordaneisenburger
Copy link
Member

Jordaneisenburger commented Mar 10, 2020

Screenshot 2020-03-10 at 16 58 07

@soumya-ashok exactly, as a user I don't want to lose context, see above image (it's Dutch but you get the point) The same applies for the filters in some way, we should be able to see active filters or an indicator that there are filters active when the drawer is closed.

@soumya-ashok
Copy link

@Jordaneisenburger - Agree with your feedback on providing context to the user. However, the way we are currently set up with the placement of the buttons for filter and sort (particularly on mobile) makes it challenging to implement something that looks like your screenshot in terms of having the space to add the additional text outside the dropdown.

@schensley has some ways we could make the design look consistent on both desktop and mobile. @larsroettig could you please work with the design that Scott provides to make improvements?

@schensley
Copy link

schensley commented Mar 10, 2020

Hi. @larsroettig
I am in agreement with @Jordaneisenburger, in that it's best to give the shopper context as to how the page is sorted without requiring them to perform some action (i.e. click to view a dropdown list). Obviously layout can present some challenges when for instance stacking controls may push products/content down the page. One tweak that could be made to the current Venia design is to display some text when the page has been sorted to indicate and confirm the criteria that the page is sorted by. Something like a line of text that reads "Products currently sorted by [Price - low to high]" just above the products. Personally, I think this text treatment could help separate sorting criteria from applied filters (tags) for the shopper - as opposed to using the same treatment for both.
Please let me know if there is anything more I can provide or clarify.

NOTE: I've made a simple wireframe demo.
https://xd.adobe.com/view/063b0a53-2f4f-41f2-67a5-2b70e6a51f8f-700a/

@codynguyen1
Copy link
Member

@Jordaneisenburger if you are going to update this, then the product listing sorting option would also be updated right?

@awilcoxa
Copy link
Author

@larsroettig any updates?

@larsroettig
Copy link
Member

@awilcoxa I started working on it but then I have to move

dpatil-magento added a commit that referenced this issue Apr 14, 2020
* #2227: Add Sort to search page

* 2227: Review fixes

* Review cleanup

* Remove italics

* Flip best match sort direction

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Eligible for community contribution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants