Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Category Sorting with Venia (PWA) #360

Closed
4 tasks
ericerway opened this issue Oct 15, 2018 · 13 comments · Fixed by #2133
Closed
4 tasks

[feature]: Category Sorting with Venia (PWA) #360

ericerway opened this issue Oct 15, 2018 · 13 comments · Fixed by #2133
Assignees
@larsroettig
Labels
help wanted Eligible for community contribution. pkg:peregrine pkg:venia-concept

Comments

@ericerway
Copy link

ericerway commented Oct 15, 2018 •
edited by soumya-ashok
Loading

This issue is for the following packages:

[X] venia-concept
[ ] pwa-buildpack
[ ] peregrine
[ ] pwa-module
[ ] pwa-devdocs

Description

https://magento.invisionapp.com/share/WQN5F7BYBPG#/324119989_Product_Sort

JIRA issue for design

https://jira.corp.magento.com/browse/UXD-181

Screen: Category with Filter and Sort
image

Screen: Sort By with Category
image

As a shopper, I want to filter and sort products within a category so that I can make a purchase on Venia.

  • Price: Low to High
  • Price: High to Low
  • Featured
  • Newest
  • Best Selling
  • Ratings: High to Low (non-MVP)

Assumptions

  • Dependent on Category page and ability to retrieve products by category
  • Ratings not part of MVP (concept only)
  • Sorting will be done SSR
  • Dependency on collection filtering variable support; follow-up with graphql-ce

Tasks
@ericerway ericerway mentioned this issue Oct 15, 2018
Closed
4 tasks
@ericerway ericerway changed the title Implement My Account menu for Venia (PWA) Implement filtering and sorting for Category with Venia (PWA) Oct 15, 2018
@ericerway ericerway changed the title Implement filtering and sorting for Category with Venia (PWA) Implement sorting for Category with Venia (PWA) Oct 15, 2018
@ericerway ericerway mentioned this issue Oct 15, 2018
Closed
3 tasks
@ericerway ericerway added for-grooming Candidate for team grooming on Friday with Community. hold On hold until another condition is fulfilled. and removed for-grooming Candidate for team grooming on Friday with Community. labels Oct 18, 2018
@ericerway ericerway added for-grooming Candidate for team grooming on Friday with Community. and removed hold On hold until another condition is fulfilled. labels Dec 13, 2018
@JStein92
Copy link
Contributor

UI is done on this - Currently waiting for magento/graphql-ce#259 to be fixed/merged so we can use query variables for sorting

@cherdman cherdman added hold On hold until another condition is fulfilled. and removed for-grooming Candidate for team grooming on Friday with Community. labels Jan 23, 2019
@cherdman
Copy link
Contributor

Blocked by magento/graphql-ce#259

@awilcoxa
Copy link

GraphQL dependency is marked as merged, appears that progress on this issue should resume. Moving back to ready to start for evaluation.

@awilcoxa awilcoxa removed the hold On hold until another condition is fulfilled. label Feb 19, 2019
@JStein92
Copy link
Contributor

@awilcoxa I believe this is still not possible. Variable queries using Objects is in 2.3.1, not 2.3.0.

@awilcoxa
Copy link

@JStein92 good call out, putting issue back on hold.

@awilcoxa awilcoxa added the hold On hold until another condition is fulfilled. label Feb 26, 2019
@supernova-at
Copy link
Contributor

@JStein92 you mentioned

UI is done on this

Is there an open PR that should be attached to this issue?

@supernova-at supernova-at removed the hold On hold until another condition is fulfilled. label Mar 21, 2019
@awilcoxa awilcoxa added the help wanted Eligible for community contribution. label May 6, 2019
@awilcoxa awilcoxa added this to the Storefront and Theming milestone Sep 16, 2019
@awilcoxa awilcoxa changed the title Implement sorting for Category with Venia (PWA) [feature]: Category Sorting with Venia (PWA) Oct 16, 2019
@awilcoxa
Copy link

Revisit of previously completed design and UI from previous PR, needs evaluation of GraphQL dependency

@cherdman
Copy link
Contributor

https://jira.corp.magento.com/browse/PWA-73

@soumya-ashok
Copy link

Scott and I have reviewed sort, some design changes need to be made. Will be working on that this week @awilcoxa .

@awilcoxa awilcoxa removed this from the Storefront and Theming milestone Jan 27, 2020
@larsroettig
Copy link
Member

larsroettig commented Jan 31, 2020 •
edited
Loading

@awilcoxa i will work on it

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

@soumya-ashok
Copy link

@larsroettig Thanks for picking this up. @schensley will be sharing the desktop mocks and working with you on implementation.

Mobile XD prototype : https://xd.adobe.com/view/15934509-f803-4dc8-7075-885b7e9e7407-63a2/

Screens:
Product Sort

Product Sort – 2

Product Sort – 3

Product Sort – 4

@schensley
Copy link

Sorting for desktop
Venia_Cart_Desktop_00
Venia_Cart_Desktop_01_SortingOptions
Venia_Cart_Desktop_02_HoverState

@larsroettig larsroettig mentioned this issue Feb 2, 2020
Merged
2 tasks
@gamul
Copy link

gamul commented Feb 4, 2020

The same button "Filter" opens an MODAL section. Early mocks for sorting were also with modal bottom drawer. Why have you changed your mind?!
Why do we get new UI element instead of stylish, unified and predictable UI?!

dpatil-magento added a commit that referenced this issue Feb 24, 2020
@jimbo @dpatil-magento
Add new categorySort Element #360 (#2133)
242f547 
* Add new categorySort Element #360

* Impelement Sort for Category #360

* #360 Refactoring after Review

* #360 Add a jest test and cleanup

* #360 Fix eslint

* Fixes after Review

* Update packages/venia-ui/lib/components/CategorySort/categorySort.js

Co-Authored-By: Jimmy Sanford <jimbo@users.noreply.github.com>

* 360: Fix review comments for sort element.

Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com>
Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
@awilcoxa awilcoxa mentioned this issue Mar 9, 2020
Closed
6 tasks
@sharkySharks sharkySharks mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsroettig larsroettig

Labels
help wanted Eligible for community contribution. pkg:peregrine pkg:venia-concept
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new categorySort Element #360
10 participants
@ericerway @larsroettig @pcvonz @supernova-at @schensley @soumya-ashok @JStein92 @gamul @cherdman @awilcoxa