Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]: Reference to @apollo/react-hooks breaks #3038

Closed
1 of 2 tasks
sta1r opened this issue Mar 3, 2021 · 3 comments · Fixed by #3039
Closed
1 of 2 tasks

[doc]: Reference to @apollo/react-hooks breaks #3038

sta1r opened this issue Mar 3, 2021 · 3 comments · Fixed by #3039
Assignees
Labels
documentation This pertains to documentation. Progress: done

Comments

@sta1r
Copy link
Contributor

sta1r commented Mar 3, 2021

Describe the request
In this tutorial https://magento.github.io/pwa-studio/tutorials/intercept-a-target/modify-talon-results/ there is a line that needs updating.

import { useQuery } from "@apollo/react-hooks";

The package.json above does not list a dependency on @apollo/react-hooks so this breaks the demo.

Possible solutions
Replace the line with:

import { useQuery } from "@apollo/client";

and update the dependency in package.json to "@apollo/client": "~3.0.0".

Screenshots
Screenshot 2021-03-03 at 17 23 29

Please let us know whether this is a new topic or a topic change request:

  • New Topic Request (ie. missing entire topic/section)
  • Topic Change Request (ie. spelling, organization)
@sta1r sta1r added the documentation This pertains to documentation. label Mar 3, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2021

Hi @sta1r. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


sta1r added a commit to sta1r/pwa-studio that referenced this issue Mar 3, 2021
sta1r added a commit to sta1r/pwa-studio that referenced this issue Mar 3, 2021
@sirugh
Copy link
Contributor

sirugh commented Mar 3, 2021

@magento export issue to JIRA project PWA as Task

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1493) is successfully created for this issue.

sta1r added a commit to sta1r/pwa-studio that referenced this issue Mar 4, 2021
dpatil-magento added a commit to sta1r/pwa-studio that referenced this issue Mar 4, 2021
dpatil-magento added a commit that referenced this issue Mar 4, 2021
* Use @apollo/client fixes #3038

* Update @apollo/client version

Co-authored-by: Stephen <sirugh@users.noreply.github.com>

Co-authored-by: Stephen <sirugh@users.noreply.github.com>
Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This pertains to documentation. Progress: done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants