Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3038 Use @apollo/client in "Modify talon results" tutorial #3039

Merged
merged 5 commits into from
Mar 4, 2021
Merged

#3038 Use @apollo/client in "Modify talon results" tutorial #3039

merged 5 commits into from
Mar 4, 2021

Conversation

sta1r
Copy link
Contributor

@sta1r sta1r commented Mar 3, 2021 •
edited
Loading

Description

Replaces the reference to @apollo/react-hooks with @apollo/client in line with other packages in PWA studio v8.0.0.

Related Issue

Closes #3038.

Verification Steps

  1. Follow this tutorial https://magento.github.io/pwa-studio/tutorials/intercept-a-target/modify-talon-results/
  2. Add the created extension to your main PWA studio project
  3. Ensure the site compiles and behaves as expected.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 3, 2021 •
edited
Loading

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 77c234e

sta1r and others added 2 commits March 4, 2021 10:09
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 4, 2021
@dpatil-magento dpatil-magento merged commit 89a4422 into magento:develop Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh left review comments

@jcalcaben jcalcaben jcalcaben approved these changes

Assignees

@sirugh sirugh

@jcalcaben jcalcaben

Labels
Progress: done tech-partners-contribution Technology Partner: dotdigital version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc]: Reference to @apollo/react-hooks breaks
6 participants
@sta1r @PWAStudioBot @sirugh @jcalcaben @magento-engcom-team @dpatil-magento