Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Checkout MVP for PWA #68

Closed
ericerway opened this issue Jun 21, 2018 · 3 comments
Closed

Implement Checkout MVP for PWA #68

ericerway opened this issue Jun 21, 2018 · 3 comments

Comments

@ericerway
Copy link

ericerway commented Jun 21, 2018

This issue is for the following packages:

[X] venia-concept
[ ] pwa-buildpack
[X] peregrine
[ ] pwa-module
[ ] pwa-devdocs

This issue is a:

[ ] Bug
[X] Feature suggestion
[ ] Documentation issue
[ ] Other (Please Specify)

Environment

Question Answer
Magento version
Operating System + version
node.js version (node -v)
npm version (npm -v)

Description

As a shopper, I want to make a purchase from the Magento PWA store (unstyled) that has already been added to cart so that I can understand how Venia works in the future.

Scenario:

  • One (1) item is already in the shopping cart; likely from Category or PD [DONE]
  • Checkout is initiated by shopper (action) [DONE]
  • Shipping information captured (e.g. Veronica Costello) [WIP]
  • Shipping method is fixed (no choice) [DONE]
  • Billing address is same as shipping (assumed) [DONE]
  • Discount code and gift card not enabled [DONE]
  • Edits and validations not required [DONE]
  • Order is placed by shopper [WIP]
  • Confirmation page with order# shown (basics) [DONE]

Expected result:

Basic checkout experience with real data from Magento store using REST API that creates an order in the system with minimal changes to the interface. Utilizes current and creates new peregrine UI components with React as appropriate but only where necessary.

Requires knowledge of REST/GRAPHQL interactions with Apollo and use of current Magento 2 API.

Possible solutions:

Demo of minimal checkout experience (unstyled) through confirmation page and order placed (seen) from Magento 2 admin panel. Checkout should be built in such a way that applying Venia styling and switching to GRAPHQL (fully) is less difficult from a developer experience.

@ericerway
Copy link
Author

Almost complete; need to merge with GraphQL [SPIKE] and related work. Marking for Sprint 20 to complete and updating estimate. Linking to newly created Venia sample data issue.

@ericerway
Copy link
Author

Updating for Sprint 21 to include editable shipping address/method and creation of an order in Magento which will be verified in the admin. New estimate to reflect remaining work.

@ericerway ericerway modified the milestones: Sprint 21, Sprint 22 Aug 9, 2018
@ericerway
Copy link
Author

Review carried to Sprint 22.

fnhipster pushed a commit to PMET-public/pwa-studio that referenced this issue Apr 9, 2019
* fix(sw): handle dev serviceworker 404

Modified `src/index.js` to only register a service worker
if `process.env.SERVICE_WORKER_FILE_NAME` is truthy.

Modified `webpack.config.js` to set `process.env.SERVICE_WORKER_FILE_NAME`
to `false` in development mode, unless he special
`ENABLE_SERVICE_WORKER_DEBUGGING` env var is trut.

Fixes magento#64.

* fix(sw): Switch back to DefinePlugin

* style: prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants