Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop branch #298

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Merge develop branch #298

merged 2 commits into from
Sep 25, 2018

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Sep 24, 2018

This PR is a:

[x] New feature
[x] Enhancement/Optimization
[x] Refactor
[x] Bugfix
[x] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will...

Add checkout functionality, refactor redux actions, and add tests.

Additional information

This is work from my own PRs. All of it has gone through a slow and not particularly thorough review process, but it represents our weekly progress thus far.

@jimbo jimbo requested a review from zetlen September 24, 2018 17:58
@coveralls
Copy link

coveralls commented Sep 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 991

  • 0 of 352 (0.0%) changed or added relevant lines in 33 files are covered.
  • 8 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.1%) to 29.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/venia-concept/src/index.js 0 1 0.0%
packages/venia-concept/src/components/Checkout/receipt.js 0 1 0.0%
packages/venia-concept/src/actions/app/index.js 0 1 0.0%
packages/venia-concept/src/actions/checkout/index.js 0 1 0.0%
packages/venia-concept/src/actions/directory/index.js 0 1 0.0%
packages/venia-concept/src/actions/cart/index.js 0 1 0.0%
packages/venia-concept/src/shared/durations.js 0 1 0.0%
packages/venia-concept/src/components/Header/navTrigger.js 0 2 0.0%
packages/venia-concept/src/components/MiniCart/trigger.js 0 2 0.0%
packages/venia-concept/src/actions/app/actions.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/venia-concept/src/components/Checkout/form.js 1 0.0%
packages/venia-concept/src/components/Navigation/trigger.js 1 0.0%
packages/venia-concept/src/components/Header/navTrigger.js 1 0.0%
packages/venia-concept/src/components/MiniCart/miniCart.js 1 0.0%
packages/venia-concept/src/components/Checkout/flow.js 1 0.0%
packages/venia-concept/src/components/MiniCart/trigger.js 1 0.0%
packages/venia-concept/src/reducers/checkout.js 1 0.0%
packages/venia-concept/src/reducers/app.js 1 0.0%
Totals Coverage Status
Change from base Build 982: -2.1%
Covered Lines: 522
Relevant Lines: 1782
💛 - Coveralls

@jimbo
Reorganize redux, add address form
fcca400 
- refactor(redux): Reorganize actions and reducers (#212)
- feature(checkout): Add address form to checkout flow (#226)
- test(redux): Add tests for redux actions (#239)
@zetlen zetlen changed the base branch from master to release/1.0 September 25, 2018 21:16
@zetlen
Copy link
Contributor

zetlen commented Sep 25, 2018

Contributes to #70, #80, #47, and closes #150.

zetlen
zetlen approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The forms are excellent
  • The address forms are excellent
  • Coveralls is not reporting how much this increases test coverage.

LGTM

@zetlen zetlen merged commit 8f387ed into release/1.0 Sep 25, 2018
@zetlen
Copy link
Contributor

zetlen commented Sep 25, 2018

Closes #68, #147, #149, #177 as well.

@zetlen zetlen deleted the develop branch September 25, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetlen zetlen zetlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimbo @coveralls @zetlen