Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkout): Add address form #226

Merged
merged 1 commit into from
Sep 14, 2018
Merged

feat(checkout): Add address form #226

merged 1 commit into from
Sep 14, 2018

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Aug 13, 2018

This PR is a:

[x] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, a shopper will be able to input an address during checkout.

Additional information

Venia designs don't currently accommodate different shipping and billing addresses, so this address is used for both of them. That will change in the future.

@jimbo jimbo force-pushed the jimbo/address-form branch 2 times, most recently from d8c34ac to 51689e5 Compare August 13, 2018 19:23
@jimbo jimbo changed the title Add address form feat(checkout): Add address form Aug 13, 2018
@coveralls
Copy link

coveralls commented Aug 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 878

  • 0 of 78 (0.0%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.0%) to 28.796%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/venia-concept/src/components/Checkout/form.js 0 4 0.0%
packages/venia-concept/src/index.js 0 4 0.0%
packages/venia-concept/src/components/Checkout/label.js 0 8 0.0%
packages/venia-concept/src/reducers/directory.js 0 8 0.0%
packages/venia-concept/src/actions/directory.js 0 15 0.0%
packages/venia-concept/src/actions/checkout.js 0 17 0.0%
packages/venia-concept/src/components/Checkout/address.js 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
packages/venia-concept/src/index.js 1 0.0%
packages/venia-concept/src/actions/checkout.js 1 0.0%
packages/venia-concept/src/components/Checkout/form.js 2 0.0%
Totals Coverage Status
Change from base Build 874: -1.0%
Covered Lines: 519
Relevant Lines: 1836
💛 - Coveralls

@jimbo jimbo force-pushed the jimbo/redux-reorg branch 4 times, most recently from 5df5a8b to af9bb01 Compare August 13, 2018 22:25
@jimbo jimbo force-pushed the jimbo/address-form branch from 51689e5 to 19ebe31 Compare August 13, 2018 22:57
@jimbo jimbo changed the base branch from jimbo/redux-reorg to develop September 14, 2018 20:09
@jimbo jimbo force-pushed the jimbo/address-form branch from 19ebe31 to 2e92422 Compare September 14, 2018 20:09
@jimbo jimbo force-pushed the jimbo/address-form branch from 2e92422 to c690880 Compare September 14, 2018 20:16
@jimbo jimbo merged commit b92edb8 into develop Sep 14, 2018
jimbo added a commit that referenced this pull request Sep 25, 2018
@jimbo
Reorganize redux, add address form
fcca400 
- refactor(redux): Reorganize actions and reducers (#212)
- feature(checkout): Add address form to checkout flow (#226)
- test(redux): Add tests for redux actions (#239)
zetlen pushed a commit that referenced this pull request Sep 25, 2018
@jimbo @zetlen
Merge develop branch (#298)
8f387ed 
* Reorganize redux, add address form

- refactor(redux): Reorganize actions and reducers (#212)
- feature(checkout): Add address form to checkout flow (#226)
- test(redux): Add tests for redux actions (#239)

* fixup
@jimbo jimbo mentioned this pull request Dec 4, 2018
Closed
@supernova-at supernova-at deleted the jimbo/address-form branch July 25, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimbo @coveralls