Create i18n extension and add french pack

[sirugh]

Description

Uses the previous example to construct an extension that provides some maintainable translation packs.

Related Issue

Closes PWA-1071.

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. Delete venia-ui/i18n/fr_FR.json if you have it.
2. yarn venia add -D @magento/venia-sample-language-packs@0.0.1
3. yarn watch:venia using a backend with a french locale enabled.
4. Use the store switcher to change to French store view. Translations should work.

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

[sirugh]

We will have to publish the extension to npm before merging this PR.

[davemacaulay]

Why would we want to provide every install with a French language pack from an example extension? I thought this language pack was to enable testing when required?

[sirugh]

We do need a less manual way to provide it for the production deployments of master and develop as we have added a french store view to the backends to demonstrate the functionality. I believe @dpatil-magento has uploaded a copy of the fr_FR.json file to the CI system somewhere but I expect he has to manually update it.

On top of that, I had assumed we would just not include this dependency when scaffolding, but I realize that not everyone uses scaffolding (some just clone/fork) so that's probably not a valid assumption.

Sounds like we need to come up with a way optionally include this dependency, but as you are supposed to include extensions as a dependency of your project, I'm not really sure how we can do that here. Maybe in the extension we can add an environment variable to only include it when necessary?

[sirugh]

Silly me, moved this to an opt-in experience. @dpatil-magento can set up the CI to install it. Developers can add it as a dependency (or link it) locally. Just need to make sure we on the core team don't accidentally commit it to venia-concept's package.json!

[PWAStudioBot]

	Fails
🚫	A version label is required. A maintainer must add one.

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Associated JIRA tickets: PWA-1071.

Generated by 🚫 dangerJS against 6a851c1

[davemacaulay]

Why would we want to provide every install with a French language pack from an example extension? I thought this language pack was to enable testing when required?

[larsroettig]

From my point of view should be an optional dependency and only English should be shipped by default

[sirugh]

@davemacaulay @larsroettig I have removed the dependency from venia-concept and provided installation instructions :)

[tjwiebell]

Straight forward and works as expected, nice work!

FYI - you can get yarn to use your local workspace copy if you specify a version, no need to go through symlinking. This should do it: yarn venia add @magento/i18n-defaults@0.0.1 -D.

[dpatil-magento]

QA Approved.

Resolved