Cypress multiple wishlist #3218
Conversation
|
…to/pwa-studio into dev/multi-wishlist-cypress
dpatil-magento
changed the title
|
@dpatil-magento I'm getting the following error attempting to run these tests:
|
...integration-tests/src/tests/wishList/integrationTests/verifyMultipleWishlistFeatures.spec.js
Outdated
Show resolved
Hide resolved
| accountPassword | ||
| ); | ||
|
|
||
| assertCreateAccount(firstName); |
There was a problem hiding this comment.
I'd prefer only to assert the things that this specific case is testing for.
If creating an account doesn't work, that should show up as a failure within the create account section of tests.
There was a problem hiding this comment.
agreed, good call. I put it here to make sure cypress waits for account creation is complete before it goes to next step. that is visiting /wishlist route in this case. I have added comment above it, but let me know if you think of any better approach here.
| cy.intercept('POST', hitGraphqlPath, req => { | ||
| if (req.body.operationName.includes('createWishlist')) { | ||
| req.reply({ | ||
| fixture: | ||
| 'wishlist/multipleWishlist/wishlistPageCreateWishlist1.json' | ||
| }); | ||
| } | ||
| }).as('createWishlist1'); | ||
| cy.intercept('GET', getCustomerWishlistCall, { | ||
| fixture: 'wishlist/multipleWishlist/oneWishlistNoProductsPage.json' | ||
| }).as('getCustomerWishlist1'); | ||
| createWishlist('Test List1'); | ||
| cy.wait(['@getCustomerWishlist1']).its('response.body'); | ||
| cy.wait('@createWishlist1').should(result => { | ||
| expect(result.request.body.variables).to.eql({ | ||
| input: { name: 'Test List1', visibility: 'PRIVATE' } | ||
| }); | ||
| expect(result.response.body).to.exist; | ||
| }); |
There was a problem hiding this comment.
This test is described as "being able to add and remove products from wishlist", but this block of code creates an empty wishlist and asserts things about it (name, visibility).
It's fine if we have to create a wishlist as part of "being able to add and remove products from wishlist", but I would expect that to be included in something like the createWishlist helper function.
If we're asserting that a wishlist is created properly I'd expect that to happen in a separate test case focused specifically on that purpose.
There was a problem hiding this comment.
I do realize I'm coming from a Unit Testing frame of mind here, so if integration tests are intended to "test everything about wishlists" in one test, we should at least name them as such and add comments for the different blocks / ideas / areas we're testing:
it('wishlist page should work', () => {
// we can create a wishlist
// ... relevant code and assertions ...
// we can add products to a wishlist
// ... relevant code and assertions ...
// we can remove products to a wishlist
// ... relevant code and assertions ...
// etc.
});
There was a problem hiding this comment.
Yes, for sure I can add comments to clarify. It's always good to keep test simple and short when it comes to mocked data tests. But in this case, I was unable to mock account creation and to test wishlist we have to be within active session. So, to avoid account creation for every small of piece of functionality I have combined all in one.
| "data": { | ||
| "createWishlist": { | ||
| "wishlist": { | ||
| "id": "32", |
There was a problem hiding this comment.
These don't actually get created on the backend so these ids don't need to constantly be updated, right?
There was a problem hiding this comment.
No, it does not needed. As soon as page reloads or test is complete the data is wiped.
| import { productPageSelectedWishlistButton } from '../../fields/productPage'; | ||
|
|
||
| /** | ||
| * Utility function to add product to wishlist from product page |
There was a problem hiding this comment.
I don't think this comment is correct. This asserts that the product's wishlist indicator button is filled in / exists, right?
There was a problem hiding this comment.
yeah, copy/paste error :P
|
|
||
| export const productAugustaEarningsUrl = '/augusta-earrings.html'; | ||
|
|
||
| export const productAugustaEarningsName = 'Augusta Earrings'; |
There was a problem hiding this comment.
We might also consider a data structure like
const productAugustaEarrings = {
name: 'Augusta Earrings`,
url: '/augusta-earrings.html`
};
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
Description
Cypress test for multiple wishlist
Related Issue
Closes PWA-1808
Acceptance
Verification Stakeholders
Specification
Verification Steps
cd venia-integration-tests/yarn installyarn testScreenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist