Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to wishlist bug fix. #3242

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

revanth0212
Copy link
Contributor

Description

There was a bug in the wishlist dialog due to which a user would be stuck with the create dialog, unable to create a new wishlist on the PLP or the PDP page.

Related Issue

Closes PWA-1851

Acceptance

Should be able to add an item to a new or an existing wishlist.

Verification Stakeholders

@dpatil-magento

Test Plan

Go to PLP or the PDP page and try to add an item to a wishlist.

Test scenario(s) for direct fix/feature

  • Verify user is able to add an item to a new or an existing wishlist from the PLP page.
  • Verify user is able to add an item to a new or an existing wishlist from the PDP page.

Is Browser/Device testing needed?

Yes

Breaking Changes (if any)

None

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jun 17, 2021
@PWAStudioBot
Copy link
Contributor

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖

Associated JIRA tickets: PWA-1851.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against c95585f

Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre this didn't pop up until now, but a simple fix 👍 we typically like to make sure bugs are covered by a test, but that might be difficult given these are React internals. Since none of these props are marked as required, it might be good to test expected behavior when no props are passed.

We don't block approval on tests, so sending to QA.

@dpatil-magento
Copy link
Contributor

Checked with @revanth0212 and we cant have unit test for this case but we will soon have integration test part of #3218 so fix is covered.

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 85eb3f3 into develop Jun 21, 2021
@dpatil-magento dpatil-magento deleted the revanth/wishlist_add_bug_fix branch June 21, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants