Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

RaghavendraTirumalasetti · 2022-09-21T07:19:35Z

… fields)

Description

Reproduction Steps

Locations (representative sample):

Shopping Bag
Checkout - Shipping Information
Checkout - Payment

Checkout - Confirmation / Create an Account
Sign In

Visually inspect form elements

Actual Behavior

There is no indication of which form fields are required. Examples include:

Module 05b - Shopping Bag
Module 06a - Checkout - Shipping Information
Module 06b - Checkout - Payment
Module 06c - Checkout - Confirmation / Create an Account
Module 07 - Sign In

Expected Behavior

Provide visual and programmatic instructions to indicate which fields are required.

Related Issue

Closes https://jira.corp.adobe.com/browse/AC-2494

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

Resolved issues:

resolves [Issue] Fix#AC-2494 No indication of required input fields (pattern: Required… #3991: Fix#AC-2494 No indication of required input fields (pattern: Required…

… fields)

pwa-studio-bot · 2022-09-21T07:29:45Z

	Messages
📖	Associated JIRA tickets: AC-2494.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 3f7119f

… fields)

…#AC-2494

… fields)

…#AC-2494

anthoula · 2022-10-28T15:20:36Z

@magento create issue from PR

anthoula

Thanks @RaghavendraTirumalasetti - Can you please add translations to all new strings?

… fields)

…#AC-2494

anthoula

Thanks @RaghavendraTirumalasetti ! Most of these can be global translation IDs.

anthoula · 2022-11-16T17:15:07Z

packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/createAccount.js

@@ -99,6 +99,10 @@ const CreateAccount = props => {
                    <TextInput
                        field="customer.firstname"
                        autoComplete="given-name"
+                        aria-label={formatMessage({
+                            id: 'Form.fistname',


Suggested change

id: 'Form.fistname',

id: 'global.firstNameRequired',

anthoula · 2022-11-16T17:15:23Z

packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/createAccount.js

@@ -113,6 +117,10 @@ const CreateAccount = props => {
                    <TextInput
                        field="customer.lastname"
                        autoComplete="family-name"
+                        aria-label={formatMessage({
+                            id: 'Form.lastname',


Suggested change

id: 'Form.lastname',

id: 'global.lastNameRequired',

anthoula · 2022-11-16T17:15:43Z

packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/createAccount.js

@@ -127,6 +135,10 @@ const CreateAccount = props => {
                    <TextInput
                        field="customer.email"
                        autoComplete="email"
+                        aria-label={formatMessage({
+                            id: 'Form.Email',


Suggested change

id: 'Form.Email',

id: 'global.emailRequired',

anthoula · 2022-11-16T17:16:16Z

packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/createAccount.js

@@ -147,6 +159,10 @@ const CreateAccount = props => {
                        validatePassword
                    ])}
                    validateOnBlur
+                    aria-label={formatMessage({
+                        id: 'Form.Password',


Suggested change

id: 'Form.Password',

id: 'global.passwordRequired',

anthoula · 2022-11-16T17:17:00Z

packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/customerForm.js

@@ -159,6 +159,10 @@ const CustomerForm = props => {
                            id="customer_firstname"
                            data-cy="CustomerForm-firstName"
                            validate={isRequired}
+                            aria-label={formatMessage({
+                                id: 'Form.fistname',


Suggested change

id: 'Form.fistname',

id: 'global.firstNameRequired',

anthoula · 2022-11-16T17:34:24Z

packages/venia-ui/lib/components/CreateAccount/createAccount.js

@@ -119,6 +123,10 @@ const CreateAccount = props => {
                    mask={value => value && value.trim()}
                    maskOnBlur={true}
                    data-cy="customer-lastname"
+                    aria-label={formatMessage({
+                        id: 'Form.lastname',


Suggested change

id: 'Form.lastname',

id: 'global.lastNameRequired',

anthoula · 2022-11-16T17:34:37Z

packages/venia-ui/lib/components/CreateAccount/createAccount.js

@@ -137,6 +145,10 @@ const CreateAccount = props => {
                    mask={value => value && value.trim()}
                    maskOnBlur={true}
                    data-cy="customer-email"
+                    aria-label={formatMessage({
+                        id: 'Form.Email',


Suggested change

id: 'Form.Email',

id: 'global.emailRequired',

anthoula · 2022-11-16T17:34:51Z

packages/venia-ui/lib/components/CreateAccount/createAccount.js

@@ -157,6 +169,10 @@ const CreateAccount = props => {
                mask={value => value && value.trim()}
                maskOnBlur={true}
                data-cy="password"
+                aria-label={formatMessage({
+                    id: 'Form.Password',


Suggested change

id: 'Form.Password',

id: 'global.passwordRequired',

anthoula · 2022-11-16T17:35:07Z

packages/venia-ui/lib/components/SignIn/signIn.js

@@ -78,6 +78,10 @@ const SignIn = props => {
                        field="email"
                        validate={isRequired}
                        data-cy="email"
+                        aria-label={formatMessage({
+                            id: 'Form.Email',


Suggested change

id: 'Form.Email',

id: 'global.emailRequired',

anthoula · 2022-11-16T17:35:23Z

packages/venia-ui/lib/components/SignIn/signIn.js

@@ -92,6 +96,10 @@ const SignIn = props => {
                    autoComplete="current-password"
                    isToggleButtonHidden={false}
                    data-cy="password"
+                    aria-label={formatMessage({
+                        id: 'Form.Password',


Suggested change

id: 'Form.Password',

id: 'global.passwordRequired',

… fields)

…#AC-2494

dpatil-magento · 2022-11-17T21:25:53Z

run cypress

pwa-test-bot · 2022-11-17T21:25:55Z

Successfully started codebuild job for cypress

pwa-studio-bot · 2022-11-17T21:38:11Z

	Fails
🚫	`node` failed.
🚫	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to update their address book: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 3f7119f

Fix#AC-2494 No indication of required input fields (pattern: Required…

d000550

… fields)

m2-community-project bot added the Progress: ready for review label Sep 21, 2022

pwa-studio-bot added the pkg:venia-ui label Sep 21, 2022

RaghavendraTirumalasetti and others added 9 commits September 21, 2022 13:02

Fix#AC-2494 No indication of required input fields (pattern: Required…

7cf5b17

… fields)

Fix#AC-2494 No indication of required input fields (pattern: Required…

3629b47

… fields)

Fix#AC-2494 No indication of required input fields (pattern: Required…

892ff25

… fields)

AC-2494::fixed test cases

208407f

Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…

d28814b

…#AC-2494

AC-2494::fixed test cases

3aba1b2

Fix#AC-2494 No indication of required input fields (pattern: Required…

187bd2c

… fields)

Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…

0951503

…#AC-2494

Merge branch 'develop' into Fix#AC-2494

f2a06d7

m2-assistant bot mentioned this pull request Oct 28, 2022

[Issue] Fix#AC-2494 No indication of required input fields (pattern: Required… #3991

Closed

anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 14, 2022

anthoula requested changes Nov 14, 2022

View reviewed changes

m2-community-project bot assigned anthoula Nov 14, 2022

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels Nov 14, 2022

RaghavendraTirumalasetti and others added 3 commits November 16, 2022 17:44

Fix#AC-2494 No indication of required input fields (pattern: Required…

827d087

… fields)

Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…

ef4ce45

…#AC-2494

Merge branch 'develop' into Fix#AC-2494

5e54913

anthoula requested changes Nov 16, 2022

View reviewed changes

RaghavendraTirumalasetti and others added 3 commits November 17, 2022 15:23

Fix#AC-2494 No indication of required input fields (pattern: Required…

fe2bace

… fields)

Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…

d18668e

…#AC-2494

Merge branch 'develop' into Fix#AC-2494

2ed566d

anthoula approved these changes Nov 17, 2022

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: changes requested labels Nov 17, 2022

Merge branch 'develop' into Fix#AC-2494

3f7119f

dpatil-magento merged commit 68eadb7 into magento:develop Nov 18, 2022

m2-community-project bot added Progress: done and removed Progress: approved labels Nov 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

RaghavendraTirumalasetti commented Sep 21, 2022 •

edited by m2-assistant bot

Loading

pwa-studio-bot commented Sep 21, 2022 •

edited

Loading

anthoula commented Oct 28, 2022

anthoula left a comment

anthoula left a comment

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

anthoula Nov 16, 2022

dpatil-magento commented Nov 17, 2022

pwa-test-bot bot commented Nov 17, 2022

pwa-studio-bot commented Nov 17, 2022

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

Conversation

RaghavendraTirumalasetti commented Sep 21, 2022 • edited by m2-assistant bot Loading

Description

Related Issue

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

Resolved issues:

pwa-studio-bot commented Sep 21, 2022 • edited Loading

anthoula commented Oct 28, 2022

anthoula left a comment

Choose a reason for hiding this comment

anthoula left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpatil-magento commented Nov 17, 2022

pwa-test-bot bot commented Nov 17, 2022

pwa-studio-bot commented Nov 17, 2022

Log

RaghavendraTirumalasetti commented Sep 21, 2022 •

edited by m2-assistant bot

Loading

pwa-studio-bot commented Sep 21, 2022 •

edited

Loading