Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

Merged
merged 17 commits into from
Nov 18, 2022
Merged

Fix#AC-2494 No indication of required input fields (pattern: Required… #3961

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d000550
Fix#AC-2494 No indication of required input fields (pattern: Required…
Sep 21, 2022
7cf5b17
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Sep 21, 2022
3629b47
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Sep 21, 2022
892ff25
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Sep 21, 2022
208407f
AC-2494::fixed test cases
glo82145 Sep 21, 2022
d28814b
Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…
glo82145 Sep 21, 2022
3aba1b2
AC-2494::fixed test cases
glo82145 Sep 21, 2022
187bd2c
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Sep 28, 2022
0951503
Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…
RaghavendraTirumalasetti Sep 29, 2022
f2a06d7
Merge branch 'develop' into Fix#AC-2494
RaghavendraTirumalasetti Sep 29, 2022
827d087
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Nov 16, 2022
ef4ce45
Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…
RaghavendraTirumalasetti Nov 16, 2022
5e54913
Merge branch 'develop' into Fix#AC-2494
RaghavendraTirumalasetti Nov 16, 2022
fe2bace
Fix#AC-2494 No indication of required input fields (pattern: Required…
RaghavendraTirumalasetti Nov 17, 2022
d18668e
Merge branch 'Fix#AC-2494' of github.com:glo71317/pwa-studio into Fix…
RaghavendraTirumalasetti Nov 17, 2022
2ed566d
Merge branch 'develop' into Fix#AC-2494
RaghavendraTirumalasetti Nov 17, 2022
3f7119f
Merge branch 'develop' into Fix#AC-2494
dpatil-magento Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/venia-ui/i18n/en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,5 +481,15 @@
"wishlistPage.wishlistDisabledMessage": "The wishlist is not currently available.",
"wishlist.itemCountOpen": "Showing {currentCount} of {count} items in this list",
"wishlist.itemCountClosed": "You have {count} {count, plural, one {item} other {items}} in this list",
"wishlist.loadMore": "Load More"
"wishlist.loadMore": "Load More",
"global.firstNameRequired":"First Name Required",
"global.lastNameRequired":"Last Name Required",
"global.emailRequired":"Email Required",
"global.passwordRequired":"Password Required",
"global.countryRequired":"Country Required",
"global.streetAddressRequired":"Street Address Required",
"global.cityRequired":"City Required",
"global.stateRequired":"State Required",
"Form.postalCode":"ZIP / Postal Code Required",
"Form.phonenumber":"Phone Number Required"
}
8 changes: 8 additions & 0 deletions ...nts/CheckoutPage/OrderConfirmationPage/__tests__/__snapshots__/createAccount.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ exports[`CreateAccount renders CreateAccount component 1`] = `
className="input"
>
<input
aria-label="First Name Required"
autoComplete="given-name"
className="input"
id="customer.firstname"
Expand Down Expand Up @@ -87,6 +88,7 @@ exports[`CreateAccount renders CreateAccount component 1`] = `
className="input"
>
<input
aria-label="Last Name Required"
autoComplete="family-name"
className="input"
id="customer.lastname"
Expand Down Expand Up @@ -128,6 +130,7 @@ exports[`CreateAccount renders CreateAccount component 1`] = `
className="input"
>
<input
aria-label="Email Required"
autoComplete="email"
className="input"
id="customer.email"
Expand Down Expand Up @@ -170,6 +173,7 @@ exports[`CreateAccount renders CreateAccount component 1`] = `
className="input"
>
<input
aria-label="Password Required"
autoComplete="new-password"
className="input"
id="password"
Expand Down Expand Up @@ -369,6 +373,7 @@ exports[`CreateAccount renders errors 1`] = `
className="input"
>
<input
aria-label="First Name Required"
autoComplete="given-name"
className="input"
id="customer.firstname"
Expand Down Expand Up @@ -410,6 +415,7 @@ exports[`CreateAccount renders errors 1`] = `
className="input"
>
<input
aria-label="Last Name Required"
autoComplete="family-name"
className="input"
id="customer.lastname"
Expand Down Expand Up @@ -451,6 +457,7 @@ exports[`CreateAccount renders errors 1`] = `
className="input"
>
<input
aria-label="Email Required"
autoComplete="email"
className="input"
id="customer.email"
Expand Down Expand Up @@ -493,6 +500,7 @@ exports[`CreateAccount renders errors 1`] = `
className="input"
>
<input
aria-label="Password Required"
autoComplete="new-password"
className="input"
id="password"
Expand Down
16 changes: 16 additions & 0 deletions packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/createAccount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ const CreateAccount = props => {
<TextInput
field="customer.firstname"
autoComplete="given-name"
aria-label={formatMessage({
id: 'global.firstNameRequired',
defaultMessage: 'First Name Required'
})}
data-cy="OrderConfirmationPage-CreateAccount-firstName"
validate={isRequired}
validateOnBlur
Expand All @@ -113,6 +117,10 @@ const CreateAccount = props => {
<TextInput
field="customer.lastname"
autoComplete="family-name"
aria-label={formatMessage({
id: 'global.lastNameRequired',
defaultMessage: 'Last Name Required'
})}
data-cy="OrderConfirmationPage-CreateAccount-lastName"
validate={isRequired}
validateOnBlur
Expand All @@ -127,6 +135,10 @@ const CreateAccount = props => {
<TextInput
field="customer.email"
autoComplete="email"
aria-label={formatMessage({
id: 'global.emailRequired',
defaultMessage: 'Email Required'
})}
data-cy="OrderConfirmationPage-CreateAccount-email"
validate={isRequired}
validateOnBlur
Expand All @@ -147,6 +159,10 @@ const CreateAccount = props => {
validatePassword
])}
validateOnBlur
aria-label={formatMessage({
id: 'global.passwordRequired',
defaultMessage: 'Password Required'
})}
/>
<div className={classes.subscribe}>
<Checkbox
Expand Down
24 changes: 24 additions & 0 deletions ...outPage/ShippingInformation/AddressForm/__tests__/__snapshots__/customerForm.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ Array [
className="input"
>
<input
aria-label="First Name Required"
className="input"
disabled={false}
id="customer_firstname"
Expand Down Expand Up @@ -162,6 +163,7 @@ Array [
className="input"
>
<input
aria-label="Last Name Required"
className="input"
disabled={false}
id="customer_lastname"
Expand All @@ -187,6 +189,7 @@ Array [
className="country"
>
<Country
aria-label="Country Required"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -215,6 +218,7 @@ Array [
className="input"
>
<input
aria-label="Street Address Required"
className="input"
id="customer_street0"
name="street[0]"
Expand Down Expand Up @@ -313,6 +317,7 @@ Array [
className="input"
>
<input
aria-label="City Required"
className="input"
id="customer_city"
name="city"
Expand All @@ -337,6 +342,7 @@ Array [
className="region"
>
<Region
aria-label="State Required"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -368,6 +374,7 @@ Array [
className="input"
>
<input
aria-label="ZIP / Postal Code Required"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -413,6 +420,7 @@ Array [
className="input"
>
<input
aria-label="Phone Number Required"
className="input"
id="customer_telephone"
name="telephone"
Expand Down Expand Up @@ -577,6 +585,7 @@ Array [
className="input"
>
<input
aria-label="First Name Required"
className="input"
disabled={false}
id="customer_firstname"
Expand Down Expand Up @@ -623,6 +632,7 @@ Array [
className="input"
>
<input
aria-label="Last Name Required"
className="input"
disabled={false}
id="customer_lastname"
Expand All @@ -648,6 +658,7 @@ Array [
className="country"
>
<Country
aria-label="Country Required"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -676,6 +687,7 @@ Array [
className="input"
>
<input
aria-label="Street Address Required"
className="input"
id="customer_street0"
name="street[0]"
Expand Down Expand Up @@ -774,6 +786,7 @@ Array [
className="input"
>
<input
aria-label="City Required"
className="input"
id="customer_city"
name="city"
Expand All @@ -798,6 +811,7 @@ Array [
className="region"
>
<Region
aria-label="State Required"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -829,6 +843,7 @@ Array [
className="input"
>
<input
aria-label="ZIP / Postal Code Required"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -874,6 +889,7 @@ Array [
className="input"
>
<input
aria-label="Phone Number Required"
className="input"
id="customer_telephone"
name="telephone"
Expand Down Expand Up @@ -1098,6 +1114,7 @@ Array [
className="input"
>
<input
aria-label="First Name Required"
className="input"
disabled={true}
id="customer_firstname"
Expand Down Expand Up @@ -1144,6 +1161,7 @@ Array [
className="input"
>
<input
aria-label="Last Name Required"
className="input"
disabled={true}
id="customer_lastname"
Expand All @@ -1169,6 +1187,7 @@ Array [
className="country"
>
<Country
aria-label="Country Required"
validate={[Function]}
/>
</div>
Expand Down Expand Up @@ -1197,6 +1216,7 @@ Array [
className="input"
>
<input
aria-label="Street Address Required"
className="input"
id="customer_street0"
name="street[0]"
Expand Down Expand Up @@ -1295,6 +1315,7 @@ Array [
className="input"
>
<input
aria-label="City Required"
className="input"
id="customer_city"
name="city"
Expand All @@ -1319,6 +1340,7 @@ Array [
className="region"
>
<Region
aria-label="State Required"
fieldInput="region[region]"
fieldSelect="region[region_id]"
optionValueKey="id"
Expand Down Expand Up @@ -1350,6 +1372,7 @@ Array [
className="input"
>
<input
aria-label="ZIP / Postal Code Required"
className="input"
id="root"
name="postcode"
Expand Down Expand Up @@ -1395,6 +1418,7 @@ Array [
className="input"
>
<input
aria-label="Phone Number Required"
className="input"
id="customer_telephone"
name="telephone"
Expand Down
Loading