Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link and prop types #407

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix link and prop types #407

merged 1 commit into from
Oct 23, 2018

Conversation

AlexeyKaryka
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ X ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will...

Additional information

@PWAStudioBot
Copy link
Contributor

Fails
🚫

The following file(s) were not formatted with prettier. Make sure to execute npm run prettier locally prior to committing.

packages/venia-concept/src/components/PurchaseHistory/purchaseHistory.js
packages/venia-concept/src/components/PurchaseHistory/PurchaseHistoryItem/helpers.js
packages/venia-concept/src/components/PurchaseHistory/PurchaseHistoryItem/purchaseHistoryItem.js

Generated by 🚫 dangerJS

@Starotitorov Starotitorov merged commit 91211df into magento:feature/purchase-history-page Oct 23, 2018
Starotitorov pushed a commit that referenced this pull request Oct 26, 2018
@AlexeyKaryka @Starotitorov
Fix link and prop types (#407)
df6d0a2
Starotitorov pushed a commit that referenced this pull request Nov 16, 2018
@AlexeyKaryka @Starotitorov
Fix link and prop types (#407)
fc12bf7
Starotitorov pushed a commit that referenced this pull request Nov 20, 2018
@AlexeyKaryka @Starotitorov
Fix link and prop types (#407)
1788172
jimbo pushed a commit that referenced this pull request Nov 20, 2018
@Starotitorov @jimbo
Purchase history page component (#501)
5480ec6 
* Add purchase history component (#392)

* Fix link and prop types (#407)

* Finish item image

* Simple test for static part of purchase history page (#417)

* Add simple test for purchase history page and prettier a few files

* Add tests for purchase history item component

* Add some styles to filter component (#448)

* Add semantic tags in list, prettier a few files (#443)

* Convert px to rem

* Address review comments

* Update purchase history styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyKaryka @PWAStudioBot @Starotitorov