Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic tags in list #443

Conversation

AlexeyKaryka
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ X ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will...

Additional information

@vercel
Copy link

vercel bot commented Nov 2, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@PWAStudioBot
Copy link
Contributor

Fails
🚫

The following file(s) were not formatted with prettier. Make sure to execute npm run prettier locally prior to committing.

packages/venia-concept/src/components/PurchaseHistory/PurchaseHistoryItem/helpers.js
packages/venia-concept/src/components/PurchaseHistory/PurchaseHistoryItem/purchaseHistoryItem.js

Generated by 🚫 dangerJS

@AlexeyKaryka AlexeyKaryka force-pushed the fix/purchase-history-page-fix-markup branch from 5470a1e to 90275eb Compare November 2, 2018 16:16
@Starotitorov Starotitorov merged commit 5c43b0e into magento:feature/purchase-history-page Nov 5, 2018
jimbo pushed a commit that referenced this pull request Nov 20, 2018
* Add purchase history component (#392)

* Fix link and prop types (#407)

* Finish item image

* Simple test for static part of purchase history page (#417)

* Add simple test for purchase history page and prettier a few files

* Add tests for purchase history item component

* Add some styles to filter component (#448)

* Add semantic tags in list, prettier a few files (#443)

* Convert px to rem

* Address review comments

* Update purchase history styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants