Compatibility with Magento 2.3.1 #966
Conversation
…lving errors and added Category Thumbnail Label Support
venia-concept/src/queries/getCategoryList.graphql
15:21 error Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"? graphql/template-strings
packages/venia-concept/src/queries/getProductDetail.graphql
14:13 error Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"? graphql/template-strings
packages/venia-concept/src/RootComponents/Category/category.js
23:21 error Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"? graphql/template-strings
packages/venia-concept/src/RootComponents/Product/Product.js
25:17 error Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"? graphql/template-strings
- Apply schema changes to additional places not covered in original PR - Update tests to reflect changes to expected shapes/shema - Fix bug in media URL generator that didn't support http protocol
|
This pull request is automatically deployed with Now. |
- Remove unused method related to image labels that makes behavior inconsistent
There was a problem hiding this comment.
@tjwiebell Nice work! Thanks for taking this one over. Prop types will click eventually. 😅
| small_image: string | ||
| small_image: shape({ | ||
| url: string.isRequired | ||
| }) |
There was a problem hiding this comment.
| }) | |
| }).isRequired |
Because you're accessing small_image.url, render() will throw if it's not an object.
| small_image: string.isRequired, | ||
| small_image: shape({ | ||
| url: string.isRequired | ||
| }), |
There was a problem hiding this comment.
In this component, the prop type for data should be simply array. The current arrayOf(shape()) is unnecessary because Gallery does nothing with the data prop but send it along to GalleryItems; even if data were null, this component would not throw during render, even if one of its children might.
There was a problem hiding this comment.
Made this suggested change
| small_image: string.isRequired, | ||
| small_image: shape({ | ||
| url: string.isRequired | ||
| }), |
There was a problem hiding this comment.
| }), | |
| }).isRequired, |
Because you're accessing small_image.url, renderImage() will throw if it's not an object.
| small_image: string.isRequired, | ||
| small_image: shape({ | ||
| url: string.isRequired | ||
| }), |
There was a problem hiding this comment.
The name, price, and small_image prop types are unnecessary in this component. GalleryItems needs an array of objects that each have an id property in order to render successfully, but no more than that.
There was a problem hiding this comment.
Removed unnecessary props
| description: string | ||
| description: shape({ | ||
| html: string.isRequired | ||
| }) |
There was a problem hiding this comment.
| }) | |
| }).isRequired |
Because you're accessing description.html, render() will throw if it's not an object.
| url_key: string.isRequired, | ||
| small_image: shape({ | ||
| url: string.isRequired | ||
| }), |
There was a problem hiding this comment.
| }), | |
| }).isRequired, |
Because you're accessing small_image.url, render() will throw if it's not an object.
|
Closing in favor of #990 with cherry-picked commits to merge into |
Description
Make changes to Venia that supports the backwards incompatible changes to GraphQL being release with Magento 2.3.1.
Related Issue
Closes #842
Motivation and Context
Venia must be compatible with 2.3.1 release
How Has This Been Tested?
Manually tested locally and ran jest
Screenshots (if appropriate):
Proposed Labels for Change Type/Package
Checklist: