Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] [ISSUE-88] Added support for latest 2.3-develop branch by so… #653

Conversation

lewisvoncken
Copy link
Contributor

…lving errors and added Category Thumbnail Label Support

venia-concept/src/queries/getCategoryList.graphql
15:21 error Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"? graphql/template-strings

packages/venia-concept/src/queries/getProductDetail.graphql
14:13 error Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"? graphql/template-strings

packages/venia-concept/src/RootComponents/Category/category.js
23:21 error Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"? graphql/template-strings

packages/venia-concept/src/RootComponents/Product/Product.js
25:17 error Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"? graphql/template-strings

This PR is a:

  • New feature
  • Enhancement/Optimization
  • Refactor
  • Bugfix
  • Test for existing code
  • Documentation

Summary

When this pull request is merged, it will solve this issue magento/graphql-ce#88

Additional information

…lving errors and added Category Thumbnail Label Support

venia-concept/src/queries/getCategoryList.graphql
  15:21  error  Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"?  graphql/template-strings

packages/venia-concept/src/queries/getProductDetail.graphql
  14:13  error  Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"?  graphql/template-strings

packages/venia-concept/src/RootComponents/Category/category.js
  23:21  error  Field "small_image" of type "ProductImage" must have a selection of subfields. Did you mean "small_image { ... }"?  graphql/template-strings

packages/venia-concept/src/RootComponents/Product/Product.js
  25:17  error  Field "description" of type "ComplexTextValue" must have a selection of subfields. Did you mean "description { ... }"?  graphql/template-strings
@vercel
Copy link

vercel bot commented Dec 12, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@zetlen zetlen added the m2 > 2.3.0 Requires Magento > 2.3.0 functionality. label Dec 12, 2018
@awilcoxa awilcoxa requested a review from tjwiebell February 26, 2019 21:55
@tjwiebell
Copy link
Contributor

Hi @lewisvoncken,

After much delay we're ready to merge this PR and fix compatibility with 2.3.1. There are several merge conflicts with bringing the branch up to date, and wanted to give you the first option to handle those. If you're free to handle this, it's yours, otherwise I'll take care of it tomorrow morning (2/27 9AM CT). If you do push up conflict resolution, please also remove the package-lock.json from the PR.

@lewisvoncken
Copy link
Contributor Author

@tjwiebell I just looked at the merge conflict and it looks like this is no longer necessary because it seems to be fixed in a different way.

@tjwiebell
Copy link
Contributor

Rebased these changes on a new branch and created a new PR #966. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m2 > 2.3.0 Requires Magento > 2.3.0 functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants