Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates for Xcode 15.2 #28

Merged
merged 5 commits into from
Apr 8, 2024
Merged

chore: updates for Xcode 15.2 #28

merged 5 commits into from
Apr 8, 2024

Conversation

stigi
Copy link
Member

@stigi stigi commented Apr 3, 2024

What's in this PR?

This PR updates two dependencies to make them compile with Xcode 15.2:

  • Nimble (used for tests, and only referenced via Carthage, but not via Cocoapods spec and SwiftPM manifest)
  • Ably

The errors appeared when trying to install the development dependencies for working on MagicBell.xcodeproj. For this one has to first run carthage bootstrap --use-xcframeworks --no-use-binaries which resulted in these two errors (line breaks added for readability):

/Users/ullrich/Projects/magicbell-swift/Carthage/Checkouts/Nimble/Nimble.xcodeproj: warning: 
The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.10, but the range
of supported deployment target versions is 10.13 to 14.2.99. (in target 'Nimble-macOS' from project 'Nimble')
** ARCHIVE FAILED **
/Users/ullrich/Projects/magicbell-swift/Carthage/Checkouts/ably-cocoa/Ably.xcodeproj: warning:
The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range
of supported deployment target versions is 10.13 to 14.2.99. (in target 'Ably-macOS' from project 'Ably')
** ARCHIVE FAILED **

Xcode versions 14 and above only support a minimum deployment target of 10.13 (documented here).

Drive By changes

  • Fixed a few typos in the readme
  • Added a test target to the swift package manager manifest (allows to run unit tests via swift test from the CLI)

Test Plan

Carthage

To reproduce the issue and verify the fix make sure to have Carthage installed and follow these steps:

  • Clone the project
  • Run the following command in the projects root: carthage bootstrap --use-xcframeworks --no-use-binaries (⚠️ this will fail without the changes in this PR for Nimble and Ably)
  • 🍵 wait until the Carthage dependencies finished building
  • Open MagicBell.xcodeproj
  • Select the MagicBellTests target and a Simulator as a testing device
  • Press ⌘+U to build and run tests

Cocoapods

Tested by running the Example app that integrates the SDK via Cocoapods.

SwiftPM

Added a unit test target to SPM and ran the tests via swift test

from v9.2.1 to v12.3.0 with support for the current Xcode (15.2)

I was not able to bump it up to the very latest Nimble version (13.2.x) because I started running into this Quick/Nimble#992

This was likely caused by: Quick/Nimble#1108
The previous version didn't support the latest Xcode 15 and produced the following errors:
@stigi stigi marked this pull request as ready for review April 6, 2024 20:43
@unamashana unamashana requested a review from smeijer April 8, 2024 09:53
@smeijer smeijer changed the title Updates for latest Xcode (15.2) chore: updates for Xcode 15.2 Apr 8, 2024
@smeijer smeijer merged commit cc14c53 into magicbell:main Apr 8, 2024
@stigi stigi deleted the ullrich/sdk-updates branch April 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants