Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR updates two dependencies to make them compile with Xcode 15.2:
The errors appeared when trying to install the development dependencies for working on
MagicBell.xcodeproj
. For this one has to first runcarthage bootstrap --use-xcframeworks --no-use-binaries
which resulted in these two errors (line breaks added for readability):Xcode versions 14 and above only support a minimum deployment target of 10.13 (documented here).
Drive By changes
swift test
from the CLI)Test Plan
Carthage
To reproduce the issue and verify the fix make sure to have Carthage installed and follow these steps:
carthage bootstrap --use-xcframeworks --no-use-binaries
(MagicBell.xcodeproj
MagicBellTests
target and a Simulator as a testing device⌘+U
to build and run testsCocoapods
Tested by running the Example app that integrates the SDK via Cocoapods.
SwiftPM
Added a unit test target to SPM and ran the tests via
swift test