fix: ensure notification preferences JSON is parsed correctly #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from v9.2.1 to v12.3.0 with support for the current Xcode (15.2) I was not able to bump it up to the very latest Nimble version (13.2.x) because I started running into this Quick/Nimble#992 This was likely caused by: Quick/Nimble#1108
The previous version didn't support the latest Xcode 15 and produced the following errors:
smeijer
approved these changes
Apr 8, 2024
smeijer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is stacked on the following PRs which need to get merged before this one:
What's in this PR?
This PR updates the client side implementation of the notifications preferences endpoint, according to the docs.
This required changing the
user.preferencesapi, as the shape of the returned objects changed.Since the API and the object model changed I took the chance to also update the model names from
UserPreferencestoNotificationPreferenceswhich is more in line with the (current) reality.Test Plan
Added unit tests for decoding and encoding JSON structure. Tested with the example that was provided in #27
In addition I tested the functionality of
user.preferences.fetchanduser.preferences.updateagainst the live API and could retrieve and update preferences for the user in the example app (a user that defaulted to the v1 shape of thenotification_preferencesendpoint)