Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a non-emulative Lexer for PhpParser #199

Merged
merged 2 commits into from
Oct 1, 2020
Merged

use a non-emulative Lexer for PhpParser #199

merged 2 commits into from
Oct 1, 2020

Conversation

rieschl
Copy link
Contributor

@rieschl rieschl commented Sep 14, 2020

so the Parser uses the running PHP version.

fixes #196

Ocramius
Ocramius requested changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case, so that we can prevent regressions on this front?

@rieschl
Copy link
Contributor Author

rieschl commented Sep 14, 2020

Can we add a test case, so that we can prevent regressions on this front?

Hm yes I looked into it before submitting the PR but I couldn't think of an appropriate test setup.
\ComposerRequireCheckerTest\ASTLocator\LocateASTFromFilesTest already uses the non-emulative Lexer. I didn't notice it until I wrote a test that should fail but didn't 😉

So if you can think of a test case, I'd be happy to try that if I can.

@rieschl rieschl force-pushed the non-emulative-lexer branch from 330d21f to 0296c64 Compare October 1, 2020 20:44
@rieschl rieschl requested a review from Ocramius October 1, 2020 20:50
Ocramius
Ocramius approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, excellent! Also excellent work on the test \o/

@Ocramius Ocramius added this to the 2.2.0 milestone Oct 1, 2020
@Ocramius Ocramius self-assigned this Oct 1, 2020
@Ocramius Ocramius added bug dependencies Pull requests that update a dependency file enhancement labels Oct 1, 2020
@Ocramius Ocramius merged commit 6f768f8 into maglnet:master Oct 1, 2020
@rieschl
Copy link
Contributor Author

rieschl commented Oct 2, 2020

Oh, excellent! Also excellent work on the test \o/

thanks! that means a lot to me, coming from you 🙃

I didn't run the test on php8, though.

@rieschl rieschl deleted the non-emulative-lexer branch October 2, 2020 06:33
@Ocramius Ocramius modified the milestones: 2.2.0, 3.0.0 Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Syntax error, unexpected T_MATCH
2 participants
@rieschl @Ocramius