Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release docker image for Linux/ARM64 #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odidev
Copy link

@odidev odidev commented Sep 24, 2021

The following file has been created and modified:
Added buildx support in .github/workflows/build_push.yml to push docker image for arm64 and amd64 platforms using GitHub actions.
Signed-off-by: odidev odidev@puresoftware.com

Signed-off-by: odidev <odidev@puresoftware.com>
@bryanvaz
Copy link

+1 from an M1 dev team

@ghost
Copy link

ghost commented Oct 30, 2021

Can we get this merged please? :-)

@markhemstead
Copy link

Yes please!

@funkenstrahlen
Copy link

Please merge this. Looking forward to increased performance.

@amandiobm
Copy link

Any update on this?!?!

@robmosca
Copy link

robmosca commented Jan 5, 2022

+1!!

@timeverts
Copy link

@mattpavelle any word on when this might get merged?

@stronk7
Copy link

stronk7 commented Jan 27, 2022

Hi, I'm all about to get this merged coz I think it's one of the last images we need to have arm64 everywhere (apart from selenium, but that's another story). So has my +1.

Just wanted to share (and don't want to sound pretentious at all!) a link to some really similar build and publish workflow, from another repository that has some (good, IMO) details that may be applied here:

https://github.com/moodlehq/moodle-exttests/pull/22/files

Some points are:

  • It has 2 jobs (test and publish), with the former happening always (I imagine that the current travis tests can be setup in the workflow) and the later only when tests have passed and the repository is the upstream one (surely we all don't want to have own images at all, the mailhog/mailhog canonical one is enough).
  • Support, via the calculatetags action more complex tag schemas, say latest, say git tag or branch... lots of options (in the linked example we only use latest).
  • Pushes to both dockerhub and github archives.
  • Allows to set the dockerhub readme automatcally
  • 99% is parametrised via a few env variables and github secrets.

And that's it. Feel free to pick any of the ideas above, or ignore them. Just thought that it may be interesting to share it because we are already using the very same workflow in a number of repos/images and it's working well.

Thanks for all the work here! Ciao :-)

@jdelaune
Copy link

+1. A merge would be great.

@gheydon
Copy link

gheydon commented Mar 28, 2022

+1 This would be really good to get this merged.

@matthewryanscott
Copy link

➕👍 for merging … I am trusting that mailhog works for amd64 users that I support, and am glad that Docker for Mac can run it, but having ability to run it natively & on a Linux for arm64 host would be pretty sweet. 🍬

@jamslinger
Copy link

jamslinger commented Apr 10, 2022

+1 :)

@mautz-et-tong
Copy link

+1

@Lewiscowles1986
Copy link

https://github.com/CODESIGN2/mailhog-docker builds a lightweight open version. Has done for a while now.

@aheissenberger
Copy link

quickfix is to build from GitHub - e.g. docker-composer.yml:

services:
  mail:
    image: mailhog:local
    build: https://github.com/mailhog/MailHog.git

@Purek
Copy link

Purek commented Dec 17, 2022

Thank you. It has been successfully built.

@rogervila
Copy link

Thank you @aheissenberger for the trick.

@tyndyll any chances on releasing v1.0.2 with arm64 support?

@jackdpeterson
Copy link

Is this project dead or unmaintained at this point in time? Would also appreciate Aarch64 support.

@ghost
Copy link

ghost commented Dec 20, 2023

Is this project dead or unmaintained at this point in time? Would also appreciate Aarch64 support.

https://github.com/axllent/mailpit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.