Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataAdapterMixin docs #1366

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Update DataAdapterMixin docs #1366

merged 2 commits into from
Jun 7, 2017

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Jun 7, 2017

Fix incorrect docs about headersForRequest being used for ember-data versions >= 2.7.
This is on hold until emberjs/rfcs#171 gets resolved

replaces #1297 by @bartocc

@marcoow
Copy link
Member Author

marcoow commented Jun 7, 2017

This needs to be rebased on master once #1367 is merged.

Julien Palmas added 2 commits June 7, 2017 18:30
Fix incorrect docs about headersForRequest being used for ember-data versions >= 2.7.
This is on hold until emberjs/rfcs#171 gets resolved
@marcoow marcoow requested a review from stevenwu June 7, 2017 16:37
@marcoow marcoow merged commit cf09be8 into master Jun 7, 2017
@marcoow marcoow deleted the ember-data-doc-update branch June 7, 2017 18:51
@bartocc
Copy link
Contributor

bartocc commented Jun 8, 2017

Thx @marcoow !

pichfl pushed a commit to pichfl/ember-simple-auth that referenced this pull request Jun 8, 2017
* Update data-adapter-mixin.js

Fix incorrect docs about headersForRequest being used for ember-data versions >= 2.7.
This is on hold until emberjs/rfcs#171 gets resolved

* Update data-adapter-mixin.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants