Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blitzwolf_bwsh5_humidifier.yaml #1220

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Conversation

spuljko
Copy link
Contributor

@spuljko spuljko commented Oct 27, 2023

Fixed recognition problems.
Added problem and spray level

name: Current humidity
class: humidity
category: diagnostic
- entity: select
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would represent spray level as a fan entity, as I think the UI is a bit better, and it also comes with richer voice control. It means duplicating the switch between both fan and humidifier, as both require a switch, and converting the levels to percentages rather than strings.

Copy link
Contributor Author

@spuljko spuljko Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks very ugly and not user friendly in this particular case. Thera are 7 levels, so step between levels is 14.28571428571429, and converted to fan is 14.28%, 28.57% etc. How will user set level to 3 via voice control that way? I know it will step to nearest value, but I doubt that anyone will even try to set it that way...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The levels do not need to be perfectly evenly spaced. You can set them at 15%, 30%, 40%, ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter levels, this still looks ugly

@@ -1,4 +1,3 @@
# sample DPS {'1': True, '4': 'health', '5': True, '10': 24, '12': 75, '13': 55, '14': 77, '18': 'c', '19': 'cancel', '20': 0, '21': True, '22': 0, '23': 'level_1', '26': True, '35': True}
name: BlitzWolf BWSH5 humidifier
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this name under products, and add a more generic name here (just Humidifier for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will people know the difference if there is few products that are recognized as humidifier if all humidifiers has same name?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone has multiple humidifiers, they will by default receive a name with a number suffix. It is up to the user to then name the devices in a way that they will recognise them.

- represent spray level as a fan, move branding under products.
@make-all make-all merged commit 2eafe12 into make-all:main Dec 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants