Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blitzwolf_bwsh5_humidifier.yaml #1220

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Update blitzwolf_bwsh5_humidifier.yaml #1220

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22decc7
Update blitzwolf_bwsh5_humidifier.yaml
spuljko Oct 27, 2023
014d527
Update blitzwolf_bwsh5_humidifier.yaml
spuljko Oct 27, 2023
9d542bd
Fault code, optional dp 13
spuljko Oct 28, 2023
fc17030
Optional dp 13
spuljko Oct 28, 2023
0ef3efe
dp 22 water
spuljko Oct 28, 2023
596d4ab
Changes from review
make-all Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 42 additions & 17 deletions custom_components/tuya_local/devices/blitzwolf_bwsh5_humidifier.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# sample DPS {'1': True, '4': 'health', '5': True, '10': 24, '12': 75, '13': 55, '14': 77, '18': 'c', '19': 'cancel', '20': 0, '21': True, '22': 0, '23': 'level_1', '26': True, '35': True}
name: BlitzWolf BWSH5 humidifier
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this name under products, and add a more generic name here (just Humidifier for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will people know the difference if there is few products that are recognized as humidifier if all humidifiers has same name?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone has multiple humidifiers, they will by default receive a name with a number suffix. It is up to the user to then name the devices in a way that they will recognise them.

products:
- id: lqzme7o0kzhumdxr
Expand Down Expand Up @@ -40,13 +39,9 @@ primary_entity:
name: current_humidity
type: integer
- id: 22
name: unknown_22
name: fault_code
type: integer
optional: true
- id: 23
name: unknown_23
type: string
optional: true
secondary_entities:
- entity: switch
name: UV sterilization
Expand All @@ -56,6 +51,7 @@ secondary_entities:
- id: 21
name: switch
type: boolean
#optional: true
- entity: switch
name: Warm mist
icon: "mdi:fire"
Expand All @@ -64,14 +60,16 @@ secondary_entities:
- id: 26
name: switch
type: boolean
optional: true
- entity: switch
name: Plasma
icon: "mdi:dots-circle"
category: config
dps:
- id: 35
name: switch
type: boolean
type: boolean
optional: true
- entity: light
name: LED
category: config
Expand All @@ -84,17 +82,30 @@ secondary_entities:
icon: "mdi:led-on"
- dps_val: false
icon: "mdi:led-off"
- entity: sensor
deprecated: humidifier
name: Current humidity
class: humidity
category: diagnostic
- entity: select
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would represent spray level as a fan entity, as I think the UI is a bit better, and it also comes with richer voice control. It means duplicating the switch between both fan and humidifier, as both require a switch, and converting the levels to percentages rather than strings.

Copy link
Contributor Author

@spuljko spuljko Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks very ugly and not user friendly in this particular case. Thera are 7 levels, so step between levels is 14.28571428571429, and converted to fan is 14.28%, 28.57% etc. How will user set level to 3 via voice control that way? I know it will step to nearest value, but I doubt that anyone will even try to set it that way...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The levels do not need to be perfectly evenly spaced. You can set them at 15%, 30%, 40%, ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter levels, this still looks ugly

name: Spray level
icon: "mdi:heat-wave"
category: config
dps:
- id: 14
type: integer
name: sensor
class: measurement
unit: "%"
- id: 23
name: option
type: string
optional: true
mapping:
- dps_val: "level_1"
value: "Level 1 "
- dps_val: "level_2"
value: "Level 2"
- dps_val: "level_3"
value: "Level 3"
- dps_val: "level_4"
value: "Level 4"
- dps_val: "level_5"
value: "Level 5"
- dps_val: "level_6"
value: "Level 6"
- dps_val: "level_7"
value: "Level 7"
- entity: sensor
class: temperature
dps:
Expand All @@ -107,6 +118,7 @@ secondary_entities:
name: temperature_f
type: integer
unit: F
optional: true
- entity: select
name: Timer
icon: "mdi:timer"
Expand All @@ -115,6 +127,7 @@ secondary_entities:
- id: 19
name: option
type: string
optional: true
mapping:
- dps_val: "cancel"
value: "Off"
Expand Down Expand Up @@ -154,10 +167,22 @@ secondary_entities:
- id: 18
type: string
name: option
optional: true
mapping:
- dps_val: c
value: Celsius
icon: "mdi:temperature-celsius"
- dps_val: f
value: Fahrenheit
icon: "mdi:temperature-fahrenheit"
- entity: binary_sensor
name: Low water
class: problem
category: diagnostic
dps:
- id: 22
type: bitfield
name: sensor
mapping:
- dps_val: 1
value: true