Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Klarstein Iceblock Ecosmart AC #2001

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add support for Klarstein Iceblock Ecosmart AC #2001

merged 3 commits into from
Jun 28, 2024

Conversation

krie
Copy link

@krie krie commented Jun 11, 2024

Add support for Klarstein Iceblock Ecosmart AC

@krie krie changed the title Add support for Klarstein Iceblock Ecosmart Add support for Klarstein Iceblock Ecosmart AC Jun 11, 2024
@@ -0,0 +1,100 @@
name: Klarstein Iceblock Ecosmart
primary_entity:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A products section with the product id and name with branding above would be useful. The name above should be more generic, as this config may match other brands and models.

If you do not have access to the cloud info with the product id, you can get it from python -m tinytuya scan

primary_entity:
entity: climate
dps:
- id: 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you did not follow the pattern in other climate devices of combining the power switch with mode to make a combined hvac_mode that includes "off"?

Copy link
Author

@krie krie Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to have the power switch combined with the modes, but unfortunately this causes issues with changing the mode via HA, when the device is already switched on. The device won't react to this command(s) then.

I guess it's the same problem as mentioned in #1843. You answered there, that adding a separate switch would be the solution and that's why I did it here 😉

Copy link
Author

@krie krie Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@make-all But the real question is, what would be the better solution for this? Having this kind of workaround separate switch or maybe change the way commands are sent by your integration?

At least my device is apparently not the only one showing this behavior.

- move branding into products section (cmmented until product id is available)
- merge power into hvac_mode
- correct unit for timer
@make-all make-all merged commit 317c07a into make-all:main Jun 28, 2024
3 of 4 checks passed
make-all added a commit that referenced this pull request Jul 3, 2024
@krie
Copy link
Author

krie commented Jul 9, 2024

Hi @make-all,
excuse my late reply, I was on vacation 🏖️

Thanks for your review and for merging my PR!
I will open a new PR to get into your comments.

make-all added a commit that referenced this pull request Jul 9, 2024
The device appears to only support single dps changes.

PR #2001 comment
@krie krie mentioned this pull request Jul 9, 2024
@krie
Copy link
Author

krie commented Jul 9, 2024

Follow-up PR is #2096

@make-all
Copy link
Owner

make-all commented Jul 9, 2024

Sorry, I jumped the gun making the change to separate out the power and modes again, causing a conflict, so I have made the changes manually.

timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
The device appears to only support single dps changes.

PR make-all#2001 comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants