-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Klarstein Iceblock Ecosmart AC #2001
Conversation
@@ -0,0 +1,100 @@ | |||
name: Klarstein Iceblock Ecosmart | |||
primary_entity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A products section with the product id and name with branding above would be useful. The name above should be more generic, as this config may match other brands and models.
If you do not have access to the cloud info with the product id, you can get it from python -m tinytuya scan
primary_entity: | ||
entity: climate | ||
dps: | ||
- id: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why you did not follow the pattern in other climate devices of combining the power switch with mode to make a combined hvac_mode that includes "off"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to have the power switch combined with the modes, but unfortunately this causes issues with changing the mode via HA, when the device is already switched on. The device won't react to this command(s) then.
I guess it's the same problem as mentioned in #1843. You answered there, that adding a separate switch would be the solution and that's why I did it here 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@make-all But the real question is, what would be the better solution for this? Having this kind of workaround separate switch or maybe change the way commands are sent by your integration?
At least my device is apparently not the only one showing this behavior.
custom_components/tuya_local/devices/klarstein_iceblock_airconditioner.yaml
Outdated
Show resolved
Hide resolved
- move branding into products section (cmmented until product id is available) - merge power into hvac_mode - correct unit for timer
Hi @make-all, Thanks for your review and for merging my PR! |
The device appears to only support single dps changes. PR #2001 comment
Follow-up PR is #2096 |
Sorry, I jumped the gun making the change to separate out the power and modes again, causing a conflict, so I have made the changes manually. |
The device appears to only support single dps changes. PR make-all#2001 comment
Add support for Klarstein Iceblock Ecosmart AC