Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bauhn_5way_powerstrip_usb_AP5W-0624.yaml #2062

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

lukegackle
Copy link
Contributor

Adding support for the BAUHN 5-way powerboard AP5W-0624, this is a tested working config with this device.

Adding support for the BAUHN 5-way powerboard AP5W-0624, this is a tested working config with this device.
type: boolean
name: lock
optional: true
- entity: sensor
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these last three should be sensors. Attributes on another entity (Perhaps Timer 1, since they are timer related) is enough to make them available without having them cluttering the default UI and entity list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@make-all Thanks very much for the feedback, I've updated the other changes but wasn't sure what the correct syntax would be to make these ones as attributes of timer 1, is there any guidance you can provide on this one?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like the way these three are handled in aubess_2gang_switch for example (there they are on switch 1, mainly because the primary entity usually ends up with left overs, but since these are all timing related, putting them on a timer also makes sense). As long as you avoid names with special meaning for the entity, extra attributes just end up as read-only values in the state attributes for the entity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@make-all Thanks very much, I have updated the YAML to have those three sensors as attributes of timer 1 and all seems to be working 😊

@@ -0,0 +1,214 @@
name: BAUHN 5-way powerstrip with USB
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name should be without branding. Also, I only see 5 switches and no timers, so is it 4 way powerstrip with USB, or 5 way without a controlled USB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify this is a 5 way power board with 5 power outlets that are individually controllable, the USB ports are not controllable. I have removed the brand, and also the USB part from the name as it's irrelevant for the purpose of this config.

@make-all make-all merged commit c838eb9 into make-all:main Jun 30, 2024
4 checks passed
make-all added a commit that referenced this pull request Jul 3, 2024
timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants