Add MOES Motion Sensor Smart Switch #2087
Conversation
Note, this is different from MOES Motion Sensor Light
|
Sorry, the pytest tests are a single test for the config, so they stop at the first error. I think changing the "option" to "value" in all your number entities will be the last one though. |
|
I appreciate the tests existing in the first place. Sorry for not understanding the documentation better.
|
| secondary_entities: | ||
| - entity: select | ||
| category: config | ||
| name: Restore power state |
There was a problem hiding this comment.
This common config option is usually given the name "Initial state" with options "On", "Off" and "Last state". Following that naming will help when these common controls get translated in future.
| min: 5 | ||
| max: 3600 | ||
| - entity: number | ||
| name: Appointment Time |
There was a problem hiding this comment.
More obvious naming is needed for these two times. I would never guess that "Appointment" is the end of allowed hours, and "Target" is the beginning. Maybe "Sensing start time" and "Sensing end time" would be better.
I would also add the following to make the display in hours rather than minutes, so for example 7pm shows as "19.0" rather than "1140". 7:30 will show as "19.5", which isn't ideal, but I think still better than "1170".
mapping:
- scale: 60
- device naming - extra attributes - standardisation of entity names and values - clearer entity naming and scaling to convenient units for all clock time PR make-all#2087
- device naming - extra attributes - standardisation of entity names and values - clearer entity naming and scaling to convenient units for all clock time PR #2087
- device naming - extra attributes - standardisation of entity names and values - clearer entity naming and scaling to convenient units for all clock time PR make-all#2087
- rename human_presence_sensor.yaml to more specific name. There is no evidence that is is generic enough to go without some identifier. PR make-all#2153, make-all#2150, make-all#2146, make-all#2145, make-all#2143, make-all#2137, make-all#2136, make-all#2134, make-all#2116, PR make-all#2087, make-all#2033
Note, this is different from MOES Motion Sensor Light