-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for welltobe cat feeder #2150
Merged
make-all
merged 3 commits into
make-all:main
from
rorydcampbell:add-support-for-welltobe-cat-feeder
Jul 28, 2024
Merged
Add support for welltobe cat feeder #2150
make-all
merged 3 commits into
make-all:main
from
rorydcampbell:add-support-for-welltobe-cat-feeder
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Jul 26, 2024
dps: | ||
- id: 103 | ||
name: sensor | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the possible values here? Would it be better to map to percentages for a more standard battery sensor?
- simplify product name - remove explicit name and icon from problem sensor - add mapping for problem sensor - make clock type a select instead of switch - PENDING: standardise battery sensor (requires list of possible values) PR make-all#2150
make-all
added a commit
that referenced
this pull request
Jul 28, 2024
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
- simplify product name - remove explicit name and icon from problem sensor - add mapping for problem sensor - make clock type a select instead of switch - PENDING: standardise battery sensor (requires list of possible values) PR make-all#2150
timlaing
pushed a commit
to timlaing/tuya-local
that referenced
this pull request
Aug 8, 2024
- rename human_presence_sensor.yaml to more specific name. There is no evidence that is is generic enough to go without some identifier. PR make-all#2153, make-all#2150, make-all#2146, make-all#2145, make-all#2143, make-all#2137, make-all#2136, make-all#2134, make-all#2116, PR make-all#2087, make-all#2033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for WellToBe Automatic Pet Feeder (WB S36D)