[WEB-2443] fix: project favorite permission validation

[anmolsinghbhatia]

Changes:

This PR addresses the validation of the project favorite functionality for guest users. Previously, users with the guest role were able to see and favorite the project icon, which was unintended.

Reference:

[WEB-2443]

Summary by CodeRabbit

• New Features

  • Introduced user permission checks for the favorite star feature in the ProjectCard component, ensuring only authorized users can access it.

• Bug Fixes

  • Enhanced UI logic to conditionally render the favorite functionality based on user permissions.

[coderabbitai]

Walkthrough

The changes in the ProjectCard component introduce user permission checks to control the rendering of the favorite star feature. By importing the useUserPermissions hook, the component now evaluates user permissions at the WORKSPACE level, specifically checking for ADMIN or MEMBER roles. This ensures that the favorite star functionality is only visible to users with the appropriate permissions.

Changes

File	Change Summary
web/core/components/project/card.tsx	- Added user permission checks to conditionally render the favorite star feature. - Introduced shouldRenderFavorite constant based on user permissions.

Possibly related PRs

• [WEB-2391] fix: join project permission mutation #5580: The changes in this PR enhance user permission management, which is directly related to the permission checks added in the main PR for rendering the favorite star feature in the ProjectCard component.

Poem

🐇 In the garden where projects bloom,
A star shines bright, dispelling gloom.
With permissions set, the favorites gleam,
Only for those who share the dream.
So hop along, let’s celebrate,
A feature fair, it’s truly great! 🌟

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fdcd9a3 and 5b4175c.

Files selected for processing (1)

• web/core/components/project/card.tsx (3 hunks)

Additional comments not posted (5)

web/core/components/project/card.tsx (5)

32-32: LGTM!

The import statement for the useUserPermissions hook is correct.

---

36-36: LGTM!

The import statement for the user permission constants is correct.

---

55-55: LGTM!

The code changes for introducing the shouldRenderFavorite constant and using the allowPermissions function to check user permissions are correct and align with the PR objective. The permission check logic is clear and concise.

Also applies to: 61-64

---

241-255: LGTM!

The code changes for conditionally rendering the FavoriteStar component based on the shouldRenderFavorite constant are correct and align with the PR objective. The FavoriteStar component is rendered with the correct props and event handlers.

---

32-32: Overall, the code changes in this file look good to me! 👍

The changes for integrating user permissions into the ProjectCard component are implemented correctly and align well with the PR objective of restricting the favorite functionality for guest users. The permission check logic using the allowPermissions function is clear and concise, and the conditional rendering of the FavoriteStar component based on the shouldRenderFavorite constant is handled correctly.

Great job with these changes! Let me know if you have any further questions or concerns.

Also applies to: 36-36, 55-55, 61-64, 241-255

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.