[WEB-2250] fix: filter projects with create permission while selecting the project in create issue modal.

[prateekshourya29]

Issue link: WEB-2250

Summary by CodeRabbit

• New Features

  • Enhanced project member retrieval to only include active members, improving data accuracy.
  • Updated issue creation modal to only display projects the user has permission to create issues in, enhancing user experience.

• Bug Fixes

  • Resolved issues with the modal displaying when no actionable projects are available.

[coderabbitai]

Walkthrough

The changes in this pull request involve enhancements to the handling of project members and user permissions within the application. Specifically, a filter is introduced to ensure that only active project members are retrieved, and user permissions are integrated into the project selection logic in the issue modal. This results in a more accurate representation of project members and improves the user experience by aligning project options with user capabilities.

Changes

File Path	Change Summary
apiserver/plane/app/views/project/member.py	Introduced a filter to only retrieve active project members (is_active=True).
web/core/components/issues/issue-modal/base.tsx	Updated project selection logic to prioritize projects with create permissions using useUser hook instead of workspaceProjectIds.

Possibly related PRs

• [WEB-2391] fix: join project permission mutation #5580: Enhances user project role management, related to active member filtering and user permissions.
• [WEB-2443] fix: project favorite permission validation #5587: Modifications to user permission checks in the ProjectCard, connecting to active member filtering.
• [WEB-2443] fix: project intake edit permission #5588: Changes regarding project intake permissions for guest users, addressing user role management.
• [WEB-2443] fix: project member validation #5601: Updates to role validation for project members, relating to the focus on filtering active members.
• [WEB-2460] fix: role permission validation #5615: Permission validation updates relevant to managing user roles within the project context.

Suggested labels

🐛bug, 🌐frontend, ⚙️backend

Poem

In the garden of code, where rabbits play,
Active members hop, keeping troubles at bay.
With permissions in hand, the modal now gleams,
Projects align, fulfilling our dreams.
Hooray for the changes, let’s dance and rejoice,
For every small fix gives the users a voice! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 146a500 and e080f39.

Files selected for processing (2)

• apiserver/plane/app/views/project/member.py (1 hunks)
• web/core/components/issues/issue-modal/base.tsx (5 hunks)

Additional comments not posted (6)

web/core/components/issues/issue-modal/base.tsx (5)

16-16: LGTM!

The useUser hook is correctly imported along with the other hooks.

---

47-47: LGTM!

The projectsWithCreatePermissions is correctly destructured from the useUser hook.

---

63-64: LGTM!

The projectIdsWithCreatePermissions is correctly derived from projectsWithCreatePermissions using Object.keys().

---

103-104: LGTM!

The logic for setting the activeProjectId has been correctly updated to use projectIdsWithCreatePermissions instead of workspaceProjectIds. This ensures that the activeProjectId is set to a project that the user has permission to create issues in.

---

293-293: LGTM!

The condition for rendering the modal has been correctly updated to check for projectIdsWithCreatePermissions and activeProjectId. This ensures that the modal is only rendered if there are projects that the user has permission to create issues in and an active project ID is set.

apiserver/plane/app/views/project/member.py (1)

417-417: LGTM!

The added filter condition is_active=True ensures that only active project members are retrieved for the given workspace. This change aligns with the PR objective of improving the accuracy of the retrieved data by excluding inactive members. The implementation is correct and enhances the integrity of the project member information.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.