[WEB-2499] fix: project state setting dnd

[anmolsinghbhatia]

Changes:

This PR fixes the drag-and-drop bug in the project state settings.

Reference:

[WEB-2499]

Summary by CodeRabbit

• New Features

  • Enhanced drag-and-drop functionality by preventing dragging of state items when they are disabled, improving user control over interactions.

• Bug Fixes

  • Fixed an issue where state items could be dragged even when disabled.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the StateItem component located in web/core/components/project-states/state-item.tsx. The primary update is the enhancement of the canDrag function to include a check for the disabled prop, ensuring that dragging is only permitted when the component is not disabled. This adjustment refines the drag-and-drop functionality without altering the overall structure or other existing logic within the component.

Changes

File Path	Change Summary
web/core/components/project-states/state-item.tsx	Updated canDrag function to include a check for the disabled prop, refining drag-and-drop behavior.

Possibly related PRs

• [WEB-2443] fix: project member validation #5601: Modifies user role validation logic, potentially impacting user interactions similar to the drag-and-drop functionality.
• [WEB-2443] fix: join project flicker #5602: Addresses permission checks affecting user interactions, relevant to the drag-and-drop behavior changes.
• [WEB-2250] fix: filter projects with create permission while selecting the project in create issue modal. #5630: Involves user permissions in project selection, which relates to user interaction controls similar to the main PR.
• [WEB-2480] fix: project settings layout #5638: Focuses on layout changes that may influence user interaction, relevant to drag-and-drop functionality.
• [WEB-2482] fix: list layout quick action styling #5639: Enhances user interface responsiveness, pertinent to user interaction improvements in the main PR.
• [WEB-2682] fix: delete project mutation and workspace draft header validation #5843: Addresses validation and interaction issues, relating to user control aspects modified in the main PR.
• [WEB-2679] fix: draft issue empty state flicker #5848: Improves user experience by resolving flickering issues, relevant to user interaction enhancements in the main PR.

Suggested reviewers

• sriramveeraghanta
• SatishGandham

🐰 In the meadow, I hop and play,
With drag-and-drop, I lead the way.
If I'm disabled, I won't be found,
But when I'm free, I leap around!
So let the states dance with glee,
A joyful change, just wait and see! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c940a29 and 6f1cd1f.

📒 Files selected for processing (1)

• web/core/components/project-states/state-item.tsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

web/core/components/project-states/state-item.tsx (2)

70-70: Excellent enhancement to drag-and-drop functionality

The addition of the !disabled check in the canDrag function is a well-implemented improvement. This change ensures that dragging is prevented when the component is in a disabled state, which aligns perfectly with the PR objective to fix the project state setting drag-and-drop functionality.

Benefits of this change:

1. Improves user experience by preventing unintended interactions with disabled state items.
2. Enhances the component's flexibility by respecting the disabled prop.
3. Maintains consistency with the component's defined props and expected behavior.

---

Line range hint 1-194: Summary: Effective implementation of drag-and-drop fix

The changes made to the StateItem component successfully address the PR objective of fixing the project state setting drag-and-drop functionality. The modification is minimal, focused, and doesn't introduce any apparent issues to the existing codebase.

Key points:

1. The change is isolated to the canDrag function, minimizing the risk of unintended side effects.
2. The implementation respects the component's existing structure and props.
3. The fix enhances the component's behavior by preventing drag operations on disabled state items.

Overall, this change improves the user experience and component functionality without compromising the existing codebase integrity.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.