Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for writing Anopheles SNP data to the plink binary file format (shadow PR) #584

Merged
merged 55 commits into from
Dec 2, 2024

Conversation

alimanfoo
Copy link
Member

This PR shadows #515 to get GitHub actions running.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jonbrenas
Copy link
Collaborator

Tristan has included a notebook in his PR to test the PLINK converter functions. The main issue is that it creates a .bed file which raises issues with correct paths (there also seems to be a problem with authentication when he ran it locally but that’s neither here nor there). I think the best solution is to stop tracking the notebook. @alimanfoo, @ahernank, @cclarkson, @leehart, any opinion?

@tristanpwdennis
Copy link
Contributor

Hi guys, I fixed the test notebook and the local tests are now completing successfully
Cheers!

@alimanfoo
Copy link
Member Author

Thanks @tristanpwdennis, unit tests are now passing :)

Looks like the plink_convert notebook also needs to be updated though to use "output_dir" instead of "results_dir".

@tristanpwdennis
Copy link
Contributor

tristanpwdennis commented Nov 20, 2024

Whoops, sorry, please blame the psychotropic jetlag. Fixed this now, and updated the output path to be the working dir of the notebook (as opposed to a relative path on my local!). Hope this is OK?

@alimanfoo alimanfoo changed the title Add plink converter function (shadow PR) Add support for writing Anopheles SNP data to the plink binary file format (shadow PR) Nov 21, 2024
tristanpwdennis and others added 21 commits November 25, 2024 09:49
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
…to plink-converter-2024-03-26-tristanpwdennis-shadow
…ithub.com:malariagen/malariagen-data-python into plink-converter-2024-03-26-tristanpwdennis-shadow
Copy link
Collaborator

@jonbrenas jonbrenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and approved by @alimanfoo here: #515

@jonbrenas jonbrenas merged commit 5c95d71 into master Dec 2, 2024
10 checks passed
@leehart leehart deleted the plink-converter-2024-03-26-tristanpwdennis-shadow branch December 2, 2024 15:44
@alimanfoo alimanfoo added the BMGF-068808 Work supported by BMGF grant INV-068808 (MalariaGEN 2024-2027). label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMGF-068808 Work supported by BMGF grant INV-068808 (MalariaGEN 2024-2027).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants