Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a file for the code shared by all _frequencies functions #690

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jonbrenas
Copy link
Collaborator

Addresses #664 .

I moved the functions to enable the computation of frequencies and the plotting functions (which required to define a new AnophelesFrequency class). I still want to move the tests of the plotting functions to their own file instead of test_snp_frq.py.

@jonbrenas
Copy link
Collaborator Author

The tests for the plotting functions are still only on SNP frequencies. Is that good enough?

@jonbrenas
Copy link
Collaborator Author

@alimanfoo, I might have found a solution that works for what I wanted to do (namely, import shared testing functions for plotting frequencies into the various test_*_frq.pys) by telling pytest to ignore them when it reaches their file (it means that the tests now return the number of "passed", "skipped", "failed" tests (as well as warnings). I checked that when the tests are actually run when called in the relevant file, they would show a failure if they failed (i.e., they are not skipped when explicitly called).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant