Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max retries runtime attribute #117

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

ahernank
Copy link
Collaborator

@ahernank ahernank commented Jan 22, 2024

During the haplotype phasing run for Ag3.9 we have encountered some issues during the statistical phasing where multiple shards have failed due to out of memory errors.

To avoid restarting the whole run (which re-computes all shards for the ShapeIt4 task even when they completed previously), we want to enable the use of the Retry with More Memory feature on this task, which requires specifying a max number of retries.

@ahernank ahernank requested a review from alimanfoo January 22, 2024 11:57
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahernank, LGTM. Would be good to add a description to this PR to explain why we'd like to make this change, i.e., to enable use of the "retry with more memory" feature of Terra.

@ahernank ahernank merged commit e88dd12 into master Jan 22, 2024
1 check passed
@ahernank ahernank deleted the ahk_add_shapeit_mem_specs branch January 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants