Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karyotype function demonstration #52

Open
ahernank opened this issue Nov 11, 2024 · 9 comments
Open

Karyotype function demonstration #52

ahernank opened this issue Nov 11, 2024 · 9 comments
Labels

Comments

@ahernank
Copy link
Collaborator

It would be great to have (or link to) an example notebook showcasing this function, using the API example as a starting point, and including some additional explanations. Akin to the terms of use example or the diplotype clustering blog.

@ahernank ahernank added the tools label Nov 11, 2024
@alimanfoo
Copy link
Member

Thanks @ahernank, good idea. I think @sanjaynagi was contemplating a blog post on the new karyotype function possibly? If so we could advertise that.

@sanjaynagi
Copy link

sanjaynagi commented Nov 11, 2024 via email

@alimanfoo
Copy link
Member

Cool, thanks Sanj. For a map you could use all samples out of embargo, i.e., where unrestricted_use is True.

@alimanfoo
Copy link
Member

@sanjaynagi has a blog post up... https://www.sanjaycnagi.com/blog/2024-11-28-karyotyping/

We should make an update here and point to Sanj's blog.

@sanjaynagi
Copy link

Let me know if there's anything you want adding to the post, it was quite brief

@alimanfoo
Copy link
Member

Let me know if there's anything you want adding to the post, it was quite brief

Thanks @sanjaynagi. I think the main question most folks will have is how to compute karyotype frequencies and visualise them. I raised an issue over on malariagen/malariagen-data-python#652 to implement some karyotype frequencies functions. I saw you also posted some code there, thanks for that. Still there's not quite enough information there for someone else to use it, e.g., the calc_allele_freq() function is used but not defined.

How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.

In parallel we could work on adding karyotype frequencies functions into malariagen_data.

(We should also add a function to malariagen_data to make map pie chart plots!)

@sanjaynagi
Copy link

sanjaynagi commented Dec 3, 2024

Let me know if there's anything you want adding to the post, it was quite brief

Thanks @sanjaynagi. I think the main question most folks will have is how to compute karyotype frequencies and visualise them. I raised an issue over on malariagen/malariagen-data-python#652 to implement some karyotype frequencies functions. I saw you also posted some code there, thanks for that. Still there's not quite enough information there for someone else to use it, e.g., the calc_allele_freq() function is used but not defined.

Woops, will add that too

How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.

Yes, I will do this! update: I have done it

(We should also add a function to malariagen_data to make map pie chart plots!)

haha, definitely!

@alimanfoo
Copy link
Member

(We should also add a function to malariagen_data to make map pie chart plots!)

malariagen/malariagen-data-python#678

@alimanfoo
Copy link
Member

How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.

Yes, I will do this! update: I have done it

Awesome, thanks!

https://colab.research.google.com/drive/1qlhygvn1N9XFn5oQgWIoQOMIzMQkSGoE?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants