Skip to content

feat: verification of side_z in AcceptLink #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ANISH-SR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: verification of side_z in AcceptLink #2540

ANISH-SR wants to merge 1 commit into from

Conversation

@ANISH-SR
Copy link
Contributor

@ANISH-SR ANISH-SR commented Jan 1, 2026

Summary of Changes

  • Added an explicit check in process_accept_link to enforce link.side_z_pk == *side_z_account.key.
  • The instruction now fails early with DoubleZeroError::InvalidAccountOwner if the Side-Z account does not match the link.
  • Prevents accepting a link with a Side-Z device that differs from the one recorded on-chain.

Testing Verification

  • Existing tests pass.

Closes #2214

juan-malbeclabs
juan-malbeclabs approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@juan-malbeclabs juan-malbeclabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan-malbeclabs juan-malbeclabs enabled auto-merge (squash) January 12, 2026 17:47
@ANISH-SR ANISH-SR mentioned this pull request Jan 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juan-malbeclabs juan-malbeclabs juan-malbeclabs approved these changes

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Verify that link.side_z_pk == side_z_account.key in AcceptLink

2 participants

@ANISH-SR @juan-malbeclabs