Migrate delphyne-dragway to use behaviour tree-based API #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMarchi
previously approved these changes
Jul 22, 2019
hidmic
force-pushed
the
hidmic/py_trees-based-api
branch
from
ef31a3d to
2549141
Compare
BMarchi
reviewed
Aug 13, 2019
| """ | ||
| simulation = simulation_subtree.runner.get_simulation() |
There was a problem hiding this comment.
Should we get the simulation from the blackboard instead?
There was a problem hiding this comment.
Via bb_helper? It feels odd, like an implementation detail. Alternatively we could a property/attribute/method to the simulation_subtree to retrieve the simulation instead of having two levels of indirection. Thoughts?
There was a problem hiding this comment.
Oh, nevermind. I forgot that it was being used as a pretick handler. It's fine as it is.
hidmic
force-pushed
the
hidmic/py_trees-based-api
branch
from
3606af1 to
17094fe
Compare
BMarchi
previously approved these changes
Aug 21, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/py_trees-based-api
branch
from
4cbe523 to
e1dc2ec
Compare
JShep1
approved these changes
Aug 23, 2019
|
Alright, going in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Connected to maliput/delphyne#636.