Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to drake v.19.0 8d92fae65 #14

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

agalbachicar
Copy link
Collaborator

No errors at all but a few deprecated types and methods that we need to refactor. A curated extract from the full log can be found below.


/home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/maliput-multilane/src/maliput_multilane/road_curve.cc:104:94: warning: ‘drake::systems::AntiderivativeFunction<double>::SpecifiedValues’ is deprecated: 
DRAKE DEPRECATED: SpecifiedValues has been renamed IntegrableFunctionContext.
The deprecated code will be removed from Drake on or after 2020-07-01. [-Wdeprecated-declarations]
   const drake::systems::AntiderivativeFunction<double>::SpecifiedValues s_from_p_func_values(initial_p_value,
                                                                                              ^~~~~~~~~~~~~~~

/home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/maliput-multilane/src/maliput_multilane/road_curve.cc:110:7: warning: ‘drake::systems::ScalarInitialValueProblem<double>::SpecifiedValues’ is deprecated: 
DRAKE DEPRECATED: SpecifiedValues has been renamed ScalarOdeContext.
The deprecated code will be removed from Drake on or after 2020-07-01. [-Wdeprecated-declarations]
       initial_s_value, initial_p_value, default_parameters);
       ^~~~~~~~~~~~~~~
In file included from /opt/drake/include/drake/systems/analysis/antiderivative_function.h:13:0,
                 from /home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/maliput-multilane/include/maliput_multilane/road_curve.h:11,
                 from /home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/maliput-multilane/src/maliput_multilane/road_curve.cc:1:
/opt/drake/include/drake/systems/analysis/scalar_initial_value_problem.h:93:28: note: declared here
   typedef ScalarOdeContext SpecifiedValues;
                            ^~~~~~~~~~~~~~~

/home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/delphyne/src/visualization/box_car_vis.cc:37:3: warning: ‘void drake::systems::rendering::PoseBundle<T>::set_pose(int, drake::Isometry3<T>&) [with T = double; drake::Isometry3<T> = Eigen::Transform<double, 3, 1>]’ is deprecated: 
DRAKE DEPRECATED: Please use set_transform()
The deprecated code will be removed from Drake on or after 2020-09-01. [-Wdeprecated-declarations]
   result.set_pose(0, X_WM);
   ^~~~~~

/home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/delphyne/src/visualization/car_vis_applicator.cc:114:32: warning: ‘drake::Isometry3<T> drake::systems::rendering::PoseBundle<T>::get_pose(int) const [with T = double; drake::Isometry3<T> = Eigen::Transform<double, 3, 1>]’ is deprecated: 
DRAKE DEPRECATED: Please use get_transform()
The deprecated code will be removed from Drake on or after 2020-09-01. [-Wdeprecated-declarations]
     const drake::Isometry3<T>& root_pose = vehicle_poses.get_pose(i);
                                ^~~~~~~~~

/home/agalbachicar/Localwork/tri_ws/src/maliput_ws/src/delphyne/src/systems/road_path.cc:103:39: warning: ‘static drake::trajectories::PiecewisePolynomial<T> drake::trajectories::PiecewisePolynomial<T>::Cubic(const std::vector<_RealType>&, const std::vector<Eigen::Matrix<LhsScalar, -1, -1, 0> >&, bool) [with T = double]’ is deprecated: 
DRAKE DEPRECATED: This version of Cubic has been renamed to CubicWithContinuousSecondDerivatives.
The deprecated code will be removed from Drake on or after 2020-07-01. [-Wdeprecated-declarations]
   return PiecewisePolynomial<T>::Cubic(s_breaks, geo_knots);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

build.log

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

So we will need to fix the deprecation warnings for the next drake bump.
Maybe having an issue documenting this would be helpful in the future.

@agalbachicar
Copy link
Collaborator Author

I am working on them right now to make sure they are trivial name changes and not other more involved refactors. If the latter happened, I would create those tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants