Adds Vector3 Rust API. #15
Conversation
francocipollone
force-pushed
the
francocipollone/add_vector3_bindings
branch
from
19b692a
to
c0d78bd
Compare
francocipollone
force-pushed
the
francocipollone/vector3_rust_api
branch
from
6c65913
to
792a24a
Compare
| assert_eq!(v.z(), 3.0); | ||
| assert_eq!(v.norm(), (1.0_f64.powi(2) + 2.0_f64.powi(2) + 3.0_f64.powi(2)).sqrt()); | ||
| assert_eq!(v.dot(&v), 1.0_f64.powi(2) + 2.0_f64.powi(2) + 3.0_f64.powi(2)); | ||
| assert_eq!(v.cross(&v), Vector3::new(0.0, 0.0, 0.0)); |
There was a problem hiding this comment.
I wonder if we should allow also default zero initialization in the parent PR.
There was a problem hiding this comment.
Debatable based on Rust programming ways:
- https://cppfaq.rs/signatures.html?highlight=constructor#how-do-i-overload-constructors
- https://doc.rust-lang.org/nomicon/constructors.html
Note we don't have constructors, the new method is just a method, we could add another new_default method if necessary and makes sense.
| /// } | ||
| /// ``` | ||
| pub struct Vector3 { | ||
| v: cxx::UniquePtr<maliput_sys::math::ffi::Vector3>, |
There was a problem hiding this comment.
For my own understanding, is this the right way of handing intra domain memory compatibility? Using the heap?
There was a problem hiding this comment.
When creating bindings to Cpp for classes like Vector3 or such (Opaque types) we can only access to them via an indirection. --> Check https://cxx.rs/concepts.html
| } | ||
| } | ||
|
|
||
| mod tests { |
There was a problem hiding this comment.
Is it common to keep tests within the same file than the type implementation?
There was a problem hiding this comment.
Are we missing debug and non debug format checks?
There was a problem hiding this comment.
Is it common to keep tests within the same file than the type implementation?
Yes. Unit tests should be located at the same file or evean you can create a submodule for tests.
Integration Tests are the ones that are expected to be put under /root/tests folder
See:
There was a problem hiding this comment.
Are we missing debug and non debug format checks?
Not sure if I follow you, can you explain?
|
|
||
| } | ||
|
|
||
| impl Eq for Vector3 {} |
There was a problem hiding this comment.
Interesting thing about partial equality and equality traits!
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
francocipollone
force-pushed
the
francocipollone/vector3_rust_api
branch
from
792a24a
to
6e2cbaf
Compare
|
I will proceed and merge this PR @agalbachicar . Feel free to make another pass for a follow-up PR. |
🎉 New feature
Related to #14
Goes on top of #12
Summary
maliputrust packageTest it
An example using vector has been added.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.