Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings and API for RBounds, HBounds, LanePositionResult and Lane's methods #47

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Bindings and API for RBounds, HBounds, LanePositionResult and Lane's methods #47

merged 4 commits into from
Mar 26, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Mar 25, 2024 •
edited
Loading

🎉 New feature

Related to #38 #37 #17 #28

Summary

  • RBonds
  • HBounds
  • LanePositionResult
  • Lane::
    • contains
    • lane_bounds
    • segment_bounds
    • elevation_bounds
    • to_lane_position
    • to_segment_position

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Bindings for lane bounds.
478d8e3 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Bindings for Lane::Contains method.
b9689cd 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Bindings for Lane::index method.
3e73c25 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Adds ToLanePosition/ToSegmentPosition bindings.
117df4a 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
This was referenced Mar 25, 2024
Closed
Closed
Open
Open
@francocipollone francocipollone changed the title More coverage for Lane API Bindings and API for RBounds, HBounds, LanePositionResult and Lane's methods Mar 26, 2024
agalbachicar
agalbachicar approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 8501885 into main Mar 26, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/bounds branch March 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar