Softlinks were not getting created properly earlier. --always-softlin…

[rmittal87]

…k option is now fully functional

Change-Id: I21e1c9ac4214065b551272bef788611c91917796

[jonashaag]

Is there a way to test this using a unit test?

[rmittal87]

fixes #1429

[rmittal87]

@jonashaag .. need to add elfutils in the reipe of micromamba-feedstock recipe for unix. Without that build is failing.

[jonashaag]

Why do we need elfutils to check if a file is executable?

[rmittal87]

We are using elf library to check if a file is execulatble or not
Elf* elf = elf_begin(fd, ELF_C_READ, NULL);
if (!elf)
{
LOG_DEBUG << path.string() << " error calling elf_begin";
close(fd);
return false;
}

    Elf_Kind ek = elf_kind(elf);
    if (ek != ELF_K_ELF)
    {
        LOG_DEBUG << path.string() << " not an ELF file";
        close(fd);
        return false;
    }

    Elf64_Ehdr* elfhdr = elf64_getehdr(elf);
    if (!elfhdr)
    {
        LOG_DEBUG << path.string() << " error reading ELF header";
        close(fd);
        return false;
    }
    bool rc = elfhdr->e_type == ET_EXEC;

[jonashaag]

Why not just look at the executable bit or the elf header bytes?

[rmittal87]

fixed the crash, added the testcase/ package for which it was crashing. @jonashaag kidnly review