-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Empty type #1227
Merged
Merged
Bugfix: Empty type #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix_empty_type
branch
2 times, most recently
from
January 12, 2024 14:03
7efb716
to
adf99ee
Compare
willdealtry
reviewed
Jan 12, 2024
…heck if they can be appened to null
- Remove PYBOOL64 - Fix issues regarding appending empty to strings and strings to empty with dynamic schema. - Add tests for appending empty to all other types and all other types to empty
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix_empty_type
branch
from
January 22, 2024 16:33
adf99ee
to
8eb7253
Compare
… sparse map is missing it assumes all values are there
willdealtry
approved these changes
Feb 2, 2024
alexowens90
reviewed
Feb 5, 2024
alexowens90
reviewed
Feb 5, 2024
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix_empty_type
branch
from
February 5, 2024 14:59
762662a
to
ff4bcdd
Compare
Can you add a test for #1056 as well? |
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix_empty_type
branch
from
February 9, 2024 14:47
5c36769
to
c2ef852
Compare
…ing column is read
…omment suggestion
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix_empty_type
branch
from
February 15, 2024 14:45
d55c4b8
to
5684779
Compare
|
alexowens90
requested changes
Feb 15, 2024
I hadn't considered the impact on defrag before. We should merge this and open a new ticket to deal with it though, it will be a mostly orthogonal change. |
Use template type-deduced functor in Column::transform instead of folly::Function.
Related epic tracking all remaining things left to do #1339 |
20 tasks
alexowens90
requested changes
Feb 19, 2024
alexowens90
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #1107
What does this implement or fix?
Fixes how empty type interacts with other types. In general we should be able to:
Changes:
Column::truncate
is used instead of copying segment rows one by one. This should improve the performance of update.lmdb_version_store_static_and_dynamic
to cover all combinations {V1, V2} ecoding x {Static, Dynamic} schema-1
)DISCUSS
Dev TODO
pd.DataFrame({"col": []})
. Potentially mark it as xfail and fix with a later PR.Any other comments?
Checklist
Checklist for code changes...