Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Empty type #1227

Merged
merged 36 commits into from
Feb 20, 2024
Merged

Bugfix: Empty type #1227

merged 36 commits into from
Feb 20, 2024

Commits on Jan 15, 2024

  1. Add src and dest type descriptors to decode or expand. Add backfilling.

    Vasil Pashov committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e8e5fae View commit details
    Browse the repository at this point in the history

  2. Fix string backfills in emoty type. Add test cases for all types to c… 

    …heck if they can be appened to null
    Vasil Pashov committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0ab4c22 View commit details
    Browse the repository at this point in the history

  3. Add a test for appending none to int

    Vasil Pashov committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d350261 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Another batch of fixes for the empty data type 

    - Remove PYBOOL64
- Fix issues regarding appending empty to strings and strings to empty
  with dynamic schema.
- Add tests for appending empty to all other types and all other types
  to empty
    Vasil Pashov committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8eb7253 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Use boost span for flatten_and_fix_rows

    Vasil Pashov committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    840d899 View commit details
    Browse the repository at this point in the history

  2. Use TypeDescriptor constructor instead of static_cast

    Vasil Pashov committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1c97adf View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Use truncate columns on update and fix pybool type handler so that if… 

    … sparse map is missing it assumes all values are there
    Vasil Pashov committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5638585 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Complete tesing for updating with empty type colummn

    Vasil Pashov committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0efb037 View commit details
    Browse the repository at this point in the history

  2. Additional test

    Vasil Pashov committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f25b788 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. FWD declare buffer holder

    Vasil Pashov committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    17b642c View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Add a single function to handle default initialization.

    Vasil Pashov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0334f45 View commit details
    Browse the repository at this point in the history

  2. Change pybool type name so a language agnostic name bool_object

    Vasil Pashov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e3d71cb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into empty-type-fixes

    Vasil Pashov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    907f103 View commit details
    Browse the repository at this point in the history

  4. Skip nullable booleans in empty types tests

    Vasil Pashov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    868c607 View commit details
    Browse the repository at this point in the history

  5. Fix compiler warnings

    Vasil Pashov committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5f244ca View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Work on matching compiler flags

    Vasil Pashov committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3d8c784 View commit details
    Browse the repository at this point in the history

  2. Add tests for updating an empty column

    Vasil Pashov committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8d0484a View commit details
    Browse the repository at this point in the history

  3. Fix conda builds

    Vasil Pashov committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6343472 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Fix MSVC release builds

    Vasil Pashov committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0a36fe6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into empty-type-fixes

    Vasil Pashov committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    98687fa View commit details
    Browse the repository at this point in the history

  3. More MSVC compilation error fixes

    Vasil Pashov committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    093e4f6 View commit details
    Browse the repository at this point in the history

  4. Fix compilation error in MSVC for C++ unit tests

    Vasil Pashov committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ff4bcdd View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix rewrite partial segment so that it doesn't try to truncate with e… 

    …mpty ranges
    Vasil Pashov committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c2ef852 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into empty-type-fixes-2

    Vasil Pashov committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    507fdaa View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Fix string reducer for static schema when empty segment part of a str… 

    …ing column is read
    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c6c212f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into empty-type-fixes

    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b3d477f View commit details
    Browse the repository at this point in the history

  3. Add comment on how pandas handles None when dtype is bool

    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    224916d View commit details
    Browse the repository at this point in the history

  4. Use std::array for flatten_and_fix_rows instead of boost::span

    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a18f2b2 View commit details
    Browse the repository at this point in the history

  5. Refactor string pool reconstruction in segment truncation as per PR c… 

    …omment suggestion
    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3033303 View commit details
    Browse the repository at this point in the history

  6. Fix compilation errors under linux

    Vasil Pashov committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0d0c31e View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Prevent creation of sparse map for empty typed columns

    Vasil Pashov committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    5684779 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Use Column::transform when reconstructing the string pool 

    Use template type-deduced functor in Column::transform instead of
folly::Function.
    Vasil Pashov committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    275b62d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into empty-type-fixes-2

    Vasil Pashov committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e0d2c8d View commit details
    Browse the repository at this point in the history

  3. Fix MSVC compilation errors

    Vasil Pashov committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e6e3e23 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Fix string pool reconstruction by adding checks for is_a_string

    Vasil Pashov committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    aeff5a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into empty-type-fixes

    Vasil Pashov committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    380663f View commit details
    Browse the repository at this point in the history