Feature flag to use WinInet client not WinHttp #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows how to use WinInet client rather than WinHttp.
This gives better error messages in the AWS SDK logs for cert errors:
Compared to WinHttp, which just says,
However, we can't merge this without a feature flag because the SSL verification disablement doesn't seem to work with this client, the AWS SDK logs:
I've tested that this change does not affect Linux, even when the feature flag is set.