Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag to use WinInet client not WinHttp #1284

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Feature flag to use WinInet client not WinHttp #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c86d603
Use WinInet client not WinHttp
poodlewars Jan 31, 2024
f11c003
Feature flag to use WinInet client not WinHttp
poodlewars Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/arcticdb/storage/s3/s3_storage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,12 @@ auto get_s3_config(const ConfigType& conf) {
conf.max_connections();
client_configuration.connectTimeoutMs = conf.connect_timeout() == 0 ? 30000 : conf.connect_timeout();
client_configuration.requestTimeoutMs = conf.request_timeout() == 0 ? 200000 : conf.request_timeout();

const bool use_win_inet = ConfigsMap::instance()->get_int("S3Storage.UseWinINet", 0);
if (use_win_inet) {
client_configuration.httpLibOverride = Aws::Http::TransferLibType::WIN_INET_CLIENT;
}

return client_configuration;
}

Expand Down
15 changes: 15 additions & 0 deletions docs/mkdocs/docs/runtime_config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,21 @@ Values:
* 0: Do not perform SSL verification.
* 1: Perform SSL verification.

### S3Storage.UseWinINet

This setting only has an effect on the Windows operating system.

Control whether the client should use the WinINet HTTP backend rather than the default WinHTTP backend.

WinINet can provide better error messages in AWS SDK debug logs, for example for diagnosing SSL issues. See the logging
configuration section below for notes on how to set up AWS SDK debug logs.

The INet backend does not allow SSL verification to be disabled with the current AWS SDK.

Values:
* 0: Use WinHTTP
* 1: Use WinINet

### VersionStore.NumCPUThreads and VersionStore.NumIOThreads

ArcticDB uses two threadpools in order to manage computational resources:
Expand Down
Loading