Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic strings append to fixed strings issue #1346

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fix dynamic strings append to fixed strings issue #1346

merged 3 commits into from
Feb 26, 2024

Conversation

IvoDD
Copy link
Collaborator

@IvoDD IvoDD commented Feb 20, 2024 •
edited
Loading

Abstracts out merging descriptors construction

  • Deduplicates merging descriptors inside update and append
  • Fixes fixed string to dynamic string conversion
  • Fixes inconsistent column ordering with dynamic schema

Reference Issues/PRs

Fixes #1204
Fixes #1349

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@IvoDD IvoDD self-assigned this Feb 20, 2024
@IvoDD IvoDD force-pushed the fix_dynamic_fixed_strings branch 6 times, most recently from 92c32c2 to 2fe6dba Compare February 21, 2024 15:55
@IvoDD IvoDD marked this pull request as ready for review February 21, 2024 16:05
@IvoDD
Adds additional append empty tests
0e539bf 
- Used to verify the refactor afterwards works with all cases
@IvoDD
Adds a failing test to demonstrate #1349
04be34d 
- Will be fixed in a follow up commit in the same PR
@IvoDD
Abstract out building of a merged descriptor
a55dbac 
- Deduplicates merging descriptors inside update and append
- Fixes fixed string to dynamic string conversion #1204
- Fixes inconsistent column ordering when appending #1349
@IvoDD IvoDD merged commit d21e882 into master Feb 26, 2024
91 of 97 checks passed
@IvoDD IvoDD deleted the fix_dynamic_fixed_strings branch February 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 alexowens90 approved these changes

Assignees

@IvoDD IvoDD

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@IvoDD @alexowens90